CE-33708: Fixed unit tests warnings

Author: bohdan-harniuk

app/code/Magento/Customer/Test/Unit/Model/Plugin/SaveCustomerGroupExcludedWebsiteTest.php

@@ -10,8 +10,8 @@
 use Magento\Catalog\Model\Indexer\Product\Price\Processor;
 use Magento\Customer\Api\Data\GroupExtensionInterface;
 use Magento\Customer\Api\Data\GroupInterface;
-use Magento\Customer\Api\GroupRepositoryInterface;
 use Magento\Customer\Api\GroupExcludedWebsiteRepositoryInterface;
+use Magento\Customer\Api\GroupRepositoryInterface;
 use Magento\Customer\Model\Data\GroupExcludedWebsite;
 use Magento\Customer\Model\Data\GroupExcludedWebsiteFactory;
 use Magento\Customer\Model\Plugin\SaveCustomerGroupExcludedWebsite;
@@ -80,12 +80,15 @@ class SaveCustomerGroupExcludedWebsiteTest extends TestCase
      */
     private $plugin;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp(): void
     {
         $objectManagerHelper = new ObjectManager($this);
 
         $this->groupExcludedWebsiteFactory = $this->getMockBuilder(GroupExcludedWebsiteFactory::class)
-            ->setMethods(['create'])
+            ->onlyMethods(['create'])
             ->disableOriginalConstructor()
             ->getMock();
         $this->groupExcludedWebsiteRepository = $this->getMockForAbstractClass(
@@ -130,6 +133,9 @@ protected function setUp(): void
         );
     }
 
+    /**
+    * @return void
+    */
     public function testAfterSaveWithoutExtensionAttributes(): void
     {
         $this->groupExtensionInterface->method('getExcludeWebsiteIds')->willReturn(null);
@@ -139,11 +145,13 @@ public function testAfterSaveWithoutExtensionAttributes(): void
     }
 
     /**
-     * @dataProvider dataProviderNoExcludedWebsitesChanged
      * @param array $excludedWebsites
      * @param array $websitesToExclude
+     *
+     * @return void
      * @throws \Magento\Framework\Exception\CouldNotSaveException
      * @throws \Magento\Framework\Exception\LocalizedException
+     * @dataProvider dataProviderNoExcludedWebsitesChanged
      */
     public function testAfterSaveWithNoExcludedWebsitesChanged(array $excludedWebsites, array $websitesToExclude): void
     {
@@ -159,12 +167,14 @@ public function testAfterSaveWithNoExcludedWebsitesChanged(array $excludedWebsit
     }
 
     /**
-     * @dataProvider dataProviderExcludedWebsitesChanged
      * @param array $excludedWebsites
      * @param array $websitesToExclude
      * @param int $times
+     *
+     * @return void
      * @throws \Magento\Framework\Exception\CouldNotSaveException
      * @throws \Magento\Framework\Exception\LocalizedException
+     * @dataProvider dataProviderExcludedWebsitesChanged
      */
     public function testAfterSaveWithExcludedWebsitesChanged(
         array $excludedWebsites,
@@ -187,7 +197,7 @@ public function testAfterSaveWithExcludedWebsitesChanged(
             ->method('setExcludedWebsiteId')->willReturnSelf();
         $this->groupExcludedWebsiteRepository->expects(self::exactly($times))
             ->method('save')
-            ->willReturn($this->groupExcludedWebsiteResourceModel);
+            ->willReturn($this->groupExcludedWebsite);
 
         $this->priceIndexProcessor->expects(self::once())->method('getIndexer')
             ->willReturn($this->priceIndexer);
@@ -197,14 +207,17 @@ public function testAfterSaveWithExcludedWebsitesChanged(
         $this->plugin->afterSave($this->groupRepositoryInterface, $this->groupInterface, $this->groupInterface);
     }
 
+    /**
+    * @return void
+    */
     private function getAllWebsites(): void
     {
         $websiteMock1 = $this->getMockBuilder(Website::class)
-            ->setMethods(['getWebsiteId'])
+            ->addMethods(['getWebsiteId'])
             ->disableOriginalConstructor()
             ->getMock();
         $websiteMock2 = $this->getMockBuilder(Website::class)
-            ->setMethods(['getWebsiteId'])
+            ->addMethods(['getWebsiteId'])
             ->disableOriginalConstructor()
             ->getMock();
         $this->store->expects(self::once())->method('getWebsiteCollection')

app/code/Magento/WeeeGraphQl/Test/Unit/Model/Resolver/FixedProductTaxResolverTest.php

@@ -109,7 +109,9 @@ protected function setUp(): void
     }
 
     /**
-     * Verifies that exception is thrown if model is not specified
+     * Verifies that exception is thrown if model is not specified.
+     *
+     * @return void
      */
     public function testShouldThrowException(): void
     {
@@ -124,14 +126,20 @@ public function testShouldThrowException(): void
     }
 
     /**
-     * Verifies that result is empty if FPT config is disabled
+     * Verifies that result is empty if FPT config is disabled.
+     *
+     * @return void
      */
     public function testShouldReturnEmptyResult(): void
     {
         $store = $this->createMock(StoreInterface::class);
         $cartItem = $this->createMock(CartItemInterface::class);
-        $contextExtensionAttributes = $this->createMock(ContextExtensionInterface::class);
-        $contextExtensionAttributes->method('getStore')
+        $contextExtensionAttributes = $this->getMockBuilder(ContextExtensionInterface::class)
+            ->disableOriginalConstructor()
+            ->addMethods(['getStore'])
+            ->getMock();
+        $contextExtensionAttributes
+            ->method('getStore')
             ->willreturn($store);
         $this->context->method('getExtensionAttributes')
             ->willReturn($contextExtensionAttributes);
@@ -155,15 +163,20 @@ public function testShouldReturnEmptyResult(): void
     }
 
     /**
-     * @dataProvider shouldReturnResultDataProvider
      * @param int $displayType
      * @param array $expected
+     *
+     * @return void
+     * @dataProvider shouldReturnResultDataProvider
      */
     public function testShouldReturnResult(int $displayType, array $expected): void
     {
         $store = $this->createMock(StoreInterface::class);
         $cartItem = $this->createMock(CartItemInterface::class);
-        $contextExtensionAttributes = $this->createMock(ContextExtensionInterface::class);
+        $contextExtensionAttributes = $this->getMockBuilder(ContextExtensionInterface::class)
+            ->disableOriginalConstructor()
+            ->addMethods(['getStore'])
+            ->getMock();
         $contextExtensionAttributes->method('getStore')
             ->willreturn($store);
         $this->context->method('getExtensionAttributes')