Skip to content

Commit 8d8706e

Browse files
committed
Single call for getMessages()
app/code/Magento/User/Test/Unit/Observer/Backend/AuthObserverTest.php is checking for a single getMessages() call
1 parent 0abb682 commit 8d8706e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

app/code/Magento/User/Observer/Backend/AuthObserver.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,11 +199,13 @@ private function _checkExpiredPassword($latestPassword)
199199
$message = __('It\'s time to <a href="%1">change your password</a>.', $myAccountUrl);
200200
}
201201

202-
// Avoid duplicating the message
203-
$this->messageManager->getMessages()->deleteMessageByIdentifier(User::MESSAGE_ID_PASSWORD_EXPIRED);
202+
$messages = $this->messageManager->getMessages();
203+
204+
// Remove existing messages with same ID to avoid duplication
205+
$messages->deleteMessageByIdentifier(User::MESSAGE_ID_PASSWORD_EXPIRED);
204206

205207
$this->messageManager->addNoticeMessage($message);
206-
$message = $this->messageManager->getMessages()->getLastAddedMessage();
208+
$message = $messages->getLastAddedMessage();
207209
if ($message) {
208210
$message->setIdentifier(User::MESSAGE_ID_PASSWORD_EXPIRED)->setIsSticky(true);
209211
$this->authSession->setPciAdminUserIsPasswordExpired(true);

0 commit comments

Comments
 (0)