Skip to content

Commit 8d6b9c7

Browse files
author
Ievgen Shakhsuvarov
committed
MAGETWO-32775: Prepare pull request for Checkout related modules MSC
- stitic tests fix
1 parent 2c0d42f commit 8d6b9c7

File tree

15 files changed

+40
-12
lines changed

15 files changed

+40
-12
lines changed

app/code/Magento/CheckoutAgreements/Api/Data/AgreementInterface.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public function getCheckboxText();
4646
* Returns the agreement status.
4747
*
4848
* @return bool Agreement status.
49+
* @SuppressWarnings(PHPMD.BooleanGetMethodName)
4950
*/
5051
public function getIsActive();
5152

@@ -54,6 +55,7 @@ public function getIsActive();
5455
*
5556
* @return bool * true - HTML.
5657
* * false - plain text.
58+
* @SuppressWarnings(PHPMD.BooleanGetMethodName)
5759
*/
5860
public function getIsHtml();
5961
}

app/code/Magento/Directory/Model/Currency.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ public function setRates(array $rates)
158158
* @param string $id
159159
* @param string $field
160160
* @return $this
161+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
161162
*/
162163
public function load($id, $field = null)
163164
{

app/code/Magento/Payment/Model/Method/AbstractMethod.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
* @method AbstractMethod setStore()
2020
* @SuppressWarnings(PHPMD.ExcessivePublicCount)
2121
* @SuppressWarnings(PHPMD.TooManyFields)
22+
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
2223
*/
2324
abstract class AbstractMethod extends \Magento\Framework\Model\AbstractExtensibleModel implements
2425
MethodInterface,

app/code/Magento/Payment/Model/Method/Cc.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
*/
66
namespace Magento\Payment\Model\Method;
77

8+
/**
9+
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
10+
*/
811
class Cc extends \Magento\Payment\Model\Method\AbstractMethod
912
{
1013
/**
@@ -52,6 +55,7 @@ class Cc extends \Magento\Payment\Model\Method\AbstractMethod
5255
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
5356
* @param \Magento\Framework\Data\Collection\Db $resourceCollection
5457
* @param array $data
58+
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
5559
*/
5660
public function __construct(
5761
\Magento\Framework\Model\Context $context,

app/code/Magento/Payment/Model/Method/Free.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ class Free extends \Magento\Payment\Model\Method\AbstractMethod
5151
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
5252
* @param \Magento\Framework\Data\Collection\Db $resourceCollection
5353
* @param array $data
54+
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
5455
*/
5556
public function __construct(
5657
\Magento\Framework\Model\Context $context,

app/code/Magento/Quote/Api/Data/ShippingMethodInterface.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public function getBaseAmount();
8888
* Returns the value of the availability flag for the current shipping method.
8989
*
9090
* @return bool
91+
* @SuppressWarnings(PHPMD.BooleanGetMethodName)
9192
*/
9293
public function getAvailable();
9394
}

app/code/Magento/Quote/Api/PaymentMethodManagementInterface.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ interface PaymentMethodManagementInterface
1313
* @param int $cartId The cart ID.
1414
* @param \Magento\Quote\Api\Data\PaymentInterface $method The payment method.
1515
* @return int Payment method ID.
16-
* @throws \Magento\Framework\Exception\State\InvalidTransitionException The billing or shipping address is not set, or the specified payment method is not available.
1716
* @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist.
17+
* @throws \Magento\Framework\Exception\State\InvalidTransitionException The billing or shipping address
18+
* is not set, or the specified payment method is not available.
1819
*/
1920
public function set($cartId, \Magento\Quote\Api\Data\PaymentInterface $method);
2021

app/code/Magento/Quote/Api/ShippingMethodManagementInterface.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ interface ShippingMethodManagementInterface
1616
* @return bool
1717
* @throws \Magento\Framework\Exception\InputException The shipping method is not valid for an empty cart.
1818
* @throws \Magento\Framework\Exception\CouldNotSaveException The shipping method could not be saved.
19-
* @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart contains only virtual products so the shipping method does not apply.
2019
* @throws \Magento\Framework\Exception\StateException The billing or shipping address is not set.
20+
* @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart contains only virtual products
21+
* so the shipping method does not apply.
2122
*/
2223
public function set($cartId, $carrierCode, $methodCode);
2324

app/code/Magento/Quote/Model/QuoteManagement.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020

2121
/**
2222
* Class QuoteManagement
23+
*
24+
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
2325
*/
2426
class QuoteManagement implements \Magento\Quote\Api\CartManagementInterface
2527
{
@@ -102,6 +104,7 @@ class QuoteManagement implements \Magento\Quote\Api\CartManagementInterface
102104
* @param QuoteRepository $quoteRepository
103105
* @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository
104106
* @param \Magento\Customer\Model\CustomerFactory $customerModelFactory
107+
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
105108
*/
106109
public function __construct(
107110
EventManager $eventManager,

app/code/Magento/Tax/Model/Quote/ToOrderConverter.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ class ToOrderConverter
2121
* @param QuoteAddress $address
2222
* @param array $additional
2323
* @return array
24+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
2425
*/
2526
public function beforeConvert(QuoteAddressToOrder $subject, QuoteAddress $address, $additional = [])
2627
{
@@ -32,6 +33,7 @@ public function beforeConvert(QuoteAddressToOrder $subject, QuoteAddress $addres
3233
* @param QuoteAddressToOrder $subject
3334
* @param OrderInterface $order
3435
* @return OrderInterface
36+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
3537
*/
3638
public function afterConvert(QuoteAddressToOrder $subject, OrderInterface $order)
3739
{

0 commit comments

Comments
 (0)