Skip to content

Commit 8d4e4a2

Browse files
committed
Changed way to calculate values
1 parent 77d2a6c commit 8d4e4a2

File tree

2 files changed

+11
-20
lines changed

2 files changed

+11
-20
lines changed

app/code/Magento/Quote/Model/Quote.php

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2284,11 +2284,10 @@ public function validateMinimumAmount($multishipping = false)
22842284
$taxes = ($taxInclude) ? $address->getBaseTaxAmount() : 0;
22852285
foreach ($address->getQuote()->getItemsCollection() as $item) {
22862286
/** @var \Magento\Quote\Model\Quote\Item $item */
2287-
if ($includeDiscount) {
2288-
$amount = $item->getBaseRowTotal() - $item->getBaseDiscountAmount() + $taxes;
2289-
} else {
2290-
$amount = $taxInclude ? $item->getBaseRowTotalInclTax() : $item->getBaseRowTotal();
2291-
}
2287+
$amount = $includeDiscount ?
2288+
$item->getBaseRowTotal() - $item->getBaseDiscountAmount() + $taxes :
2289+
$item->getBaseRowTotal() + $taxes;
2290+
22922291
if ($amount < $minAmount) {
22932292
return false;
22942293
}
@@ -2298,11 +2297,9 @@ public function validateMinimumAmount($multishipping = false)
22982297
$baseTotal = 0;
22992298
foreach ($addresses as $address) {
23002299
$taxes = ($taxInclude) ? $address->getBaseTaxAmount() : 0;
2301-
if ($includeDiscount) {
2302-
$baseTotal += $address->getBaseSubtotalWithDiscount() + $taxes;
2303-
} else {
2304-
$baseTotal += $taxInclude ? $address->getBaseSubtotalTotalInclTax() : $address->getBaseSubtotal();
2305-
}
2300+
$baseTotal += $includeDiscount ?
2301+
$address->getBaseSubtotalWithDiscount() + $taxes :
2302+
$address->getBaseSubtotal() + $taxes;
23062303
}
23072304
if ($baseTotal < $minAmount) {
23082305
return false;

app/code/Magento/Quote/Model/Quote/Address.php

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1159,17 +1159,11 @@ public function validateMinimumAmount()
11591159
$storeId
11601160
);
11611161

1162-
if ($includeDiscount) {
1163-
$taxes = $taxInclude ? $this->getBaseTaxAmount() : 0;
1162+
$taxes = $taxInclude ? $this->getBaseTaxAmount() : 0;
11641163

1165-
$isMinimumReached = ($this->getBaseSubtotalWithDiscount() + $taxes >= $amount);
1166-
} else {
1167-
$isMinimumReached = $taxInclude
1168-
? ($this->getBaseSubtotalTotalInclTax() >= $amount)
1169-
: ($this->getBaseSubtotal() >= $amount);
1170-
}
1171-
1172-
return $isMinimumReached;
1164+
return $includeDiscount ?
1165+
($this->getBaseSubtotalWithDiscount() + $taxes >= $amount) :
1166+
($this->getBaseSubtotal() + $taxes >= $amount);
11731167
}
11741168

11751169
/**

0 commit comments

Comments
 (0)