Remove useless parentheses

Author: DanielRuf

app/code/Magento/Catalog/Controller/Adminhtml/Product/Edit.php

@@ -51,7 +51,7 @@ public function execute()
         $productId = (int) $this->getRequest()->getParam('id');
         $product = $this->productBuilder->build($this->getRequest());
 
-        if (($productId && !$product->getEntityId())) {
+        if ($productId && !$product->getEntityId()) {
             /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
             $resultRedirect = $this->resultRedirectFactory->create();
             $this->messageManager->addErrorMessage(__('This product doesn\'t exist.'));

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav.php

@@ -726,7 +726,7 @@ public function setupAttributeMeta(ProductAttributeInterface $attribute, $groupC
 
         // TODO: getAttributeModel() should not be used when MAGETWO-48284 is complete
         $childData = $this->arrayManager->get($configPath, $meta, []);
-        if (($rules = $this->catalogEavValidationRules->build($this->getAttributeModel($attribute), $childData))) {
+        if ($rules = $this->catalogEavValidationRules->build($this->getAttributeModel($attribute), $childData)) {
             $meta = $this->arrayManager->merge($configPath, $meta, ['validation' => $rules]);
         }
 

app/code/Magento/NewRelicReporting/Model/Apm/Deployments.php

@@ -88,7 +88,7 @@ public function setDeployment($description, $change = false, $user = false)
             return false;
         }
 
-        if (($response->getStatus() < 200 || $response->getStatus() > 210)) {
+        if ($response->getStatus() < 200 || $response->getStatus() > 210) {
             $this->logger->warning('Deployment marker request did not send a 200 status code.');
             return false;
         }

app/code/Magento/Persistent/Observer/MakePersistentQuoteGuestObserver.php

@@ -65,8 +65,8 @@ public function execute(\Magento\Framework\Event\Observer $observer)
         /** @var $action \Magento\Persistent\Controller\Index */
         $action = $observer->getEvent()->getControllerAction();
         if ($action instanceof \Magento\Persistent\Controller\Index) {
-            if ((($this->_persistentSession->isPersistent() && !$this->_customerSession->isLoggedIn())
-                || $this->_persistentData->isShoppingCartPersist())
+            if (($this->_persistentSession->isPersistent() && !$this->_customerSession->isLoggedIn())
+                || $this->_persistentData->isShoppingCartPersist()
             ) {
                 $this->quoteManager->setGuest(true);
             }

app/code/Magento/Ui/Component/Control/SplitButton.php

@@ -83,12 +83,12 @@ public function getButtonAttributesHtml()
             'style' => $this->getStyle(),
         ];
 
-        if (($idHard = $this->getIdHard())) {
+        if ($idHard = $this->getIdHard()) {
             $attributes['id'] = $idHard;
         }
 
         //TODO perhaps we need to skip data-mage-init when disabled="disabled"
-        if (($dataAttribute = $this->getDataAttribute())) {
+        if ($dataAttribute = $this->getDataAttribute()) {
             $this->getDataAttributes($dataAttribute, $attributes);
         }
 
@@ -112,7 +112,7 @@ public function getToggleAttributesHtml()
             $title = $this->getLabel();
         }
 
-        if (($currentClass = $this->getClass())) {
+        if ($currentClass = $this->getClass()) {
             $classes[] = $currentClass;
         }
 

dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/Product/TaxClass.php

@@ -52,7 +52,7 @@ class TaxClass extends DataSource
     public function __construct(FixtureFactory $fixtureFactory, array $params, $data = [])
     {
         $this->params = $params;
-        if ((!isset($data['dataset']) && !isset($data['tax_product_class']))) {
+        if (!isset($data['dataset']) && !isset($data['tax_product_class'])) {
             $this->data = $data;
             return;
         }

setup/src/Magento/Setup/Model/Installer.php

@@ -429,7 +429,7 @@ private function createModulesConfig($request, $dryRun = false)
         $disable = $this->readListOfModules($all, $request, InstallCommand::INPUT_KEY_DISABLE_MODULES);
         $result = [];
         foreach ($all as $module) {
-            if ((isset($currentModules[$module]) && !$currentModules[$module])) {
+            if (isset($currentModules[$module]) && !$currentModules[$module]) {
                 $result[$module] = 0;
             } else {
                 $result[$module] = 1;
@@ -925,7 +925,7 @@ private function throwExceptionForNotWritablePaths(array $paths)
      */
     private function handleDBSchemaData($setup, $type, array $request)
     {
-        if (!(($type === 'schema') || ($type === 'data'))) {
+        if (!($type === 'schema' || $type === 'data')) {
             throw  new \Magento\Setup\Exception("Unsupported operation type $type is requested");
         }
         $resource = new \Magento\Framework\Module\ModuleResource($this->context);