Skip to content

Commit 8cd9885

Browse files
committed
Done with the Minor Changes and Feedbacks
1 parent ad53a3d commit 8cd9885

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

app/code/Magento/Catalog/Test/Mftf/Test/AdminApplyTierPriceToProductTest/StoreFrontDeleteProductImagesAssignedDifferentRolesTest.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<argument name="productId" value="$simpleProductOne.id$"/>
3737
</actionGroup>
3838
<!-- Halt test execution for 10 seconds before continuing. -->
39-
<wait time="10" stepKey="waitTenSeconds"/>
39+
<wait time="10" stepKey="waitForAddImageSectionToOpen"/>
4040

4141
<!-- Add Image Base-->
4242
<actionGroup ref="AddProductImageActionGroup" stepKey="addBaseImage">
@@ -79,7 +79,7 @@
7979
<seeElement selector="{{StorefrontProductMediaSection.imageFile('/adobe-base')}}" stepKey="seeBaseImageOnProductPage"/>
8080
<!-- Go to the category page and see the Small image -->
8181
<amOnPage url="{{StorefrontCategoryPage.url($testCategory.custom_attributes[url_key]$)}}" stepKey="goToCategoryPage"/>
82-
<waitForPageLoad stepKey="waitForPageLoading"/>
82+
<waitForPageLoad stepKey="waitForPageLoadingToFinish"/>
8383
<seeElement selector="{{StorefrontCategoryProductSection.ProductImageBySrc('/adobe-small')}}" stepKey="seeSmallImageOnCategoryPage"/>
8484
</before>
8585
<after>
@@ -116,11 +116,11 @@
116116
<waitForPageLoad stepKey="waitForPageRefresh"/>
117117
<waitForElementVisible selector="{{AdminProductImagesSection.nthRemoveImageBtn('2')}}" stepKey="waitForRemoveImageButtonVisiblesmall"/>
118118
<click selector="{{AdminProductImagesSection.nthRemoveImageBtn('2')}}" stepKey="removeImagesmall"/>
119-
<actionGroup ref="SaveProductFormActionGroup" stepKey="save2"/>
119+
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProductAfterSmallImageDelete"/>
120120
<dontSeeElement selector="{{AdminProductImagesSection.imageFile(AdobeSmallImage)}}" stepKey="seeImageSmallIsAbsentAfterSave"/>
121121
<!-- Go to the category page and see Small image is not present , placeholder image is present-->
122122
<amOnPage url="{{StorefrontCategoryPage.url($testCategory.custom_attributes[url_key]$)}}" stepKey="goToCategoryPageOnStoreFront"/>
123-
<waitForPageLoad stepKey="waitforPage"/>
123+
<waitForPageLoad stepKey="waitforElementStorefrontCategoryProductSectionProductImageToOpen"/>
124124
<dontSeeElement selector="{{StorefrontCategoryProductSection.ProductImageBySrc('/adobe-small')}}" stepKey="dontSeeSmallImageOnCategoryPage"/>
125125
<seeElement selector="{{StorefrontCategoryProductSection.ProductImageBySrc('placeholder/small_image')}}" stepKey="seePlaceholderSmallInstead"/>
126126

@@ -131,14 +131,14 @@
131131
<!--Delete Base Image and Check Base Image is Absent after save-->
132132
<waitForElementVisible selector="{{AdminProductImagesSection.productImagesToggle}}" stepKey="waitForImagesSectionButton"/>
133133
<conditionalClick selector="{{AdminProductImagesSection.productImagesToggle}}" dependentSelector="{{AdminProductImagesSection.imageUploadButton}}" visible="false" stepKey="openProductImageSection"/>
134-
<waitForPageLoad stepKey="wait"/>
134+
<waitForPageLoad stepKey="waitForPageLoadAdminProductImagesSection"/>
135135
<waitForElementVisible selector="{{AdminProductImagesSection.nthRemoveImageBtn('1')}}" stepKey="waitForRemoveBaseImageButtonVisible"/>
136136
<click selector="{{AdminProductImagesSection.nthRemoveImageBtn('1')}}" stepKey="removeBaseImage"/>
137-
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProduct"/>
137+
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProductAfterBaseImageDelete"/>
138138
<dontSeeElement selector="{{AdminProductImagesSection.imageFile(TestImageAdobe)}}" stepKey="dontSeeBaseImageAfterSave"/>
139139
<!-- Go to the product page on StoreFront and Dont see the Base image -->
140140
<amOnPage url="{{StorefrontProductPage.url($simpleProductOne.custom_attributes[url_key]$)}}" stepKey="goToProductPageOnStoreFront"/>
141-
<waitForPageLoad stepKey="waitForPage"/>
141+
<waitForPageLoad stepKey="waitForStorefrontProductMediaSection"/>
142142
<dontSeeElement selector="{{StorefrontProductMediaSection.imageFile('TestImageAdobe')}}" stepKey="dontseeBaseImageOnProductPage"/>
143143
<seeElement selector="{{StorefrontProductMediaSection.imageFile('placeholder/image')}}" stepKey="seePlaceholderBaseInstead"/>
144144

0 commit comments

Comments
 (0)