MAGETWO-35141: Sequence component pull request processing

Author: sivaschenko

app/code/Magento/Sales/Setup/InstallData.php

@@ -173,26 +173,5 @@ public function install(ModuleDataSetupInterface $setup, ModuleContextInterface
                 ['state = ?' => $state]
             );
         }
-        $defaultEntityTypes = array_keys($salesSetup->getDefaultEntities());
-        foreach ($defaultEntityTypes as $entityType) {
-            $this->sequenceBuilder->setPrefix($this->sequenceConfig->get('prefix'))
-                ->setSuffix($this->sequenceConfig->get('suffix'))
-                ->setStartValue($this->sequenceConfig->get('startValue'))
-                ->setStoreId(0)
-                ->setStep($this->sequenceConfig->get('step'))
-                ->setWarningValue($this->sequenceConfig->get('warningValue'))
-                ->setMaxValue($this->sequenceConfig->get('maxValue'))
-                ->setEntityType($entityType)->create();
-        }
-        foreach ($defaultEntityTypes as $entityType) {
-            $this->sequenceBuilder->setPrefix($this->sequenceConfig->get('prefix'))
-                ->setSuffix($this->sequenceConfig->get('suffix'))
-                ->setStartValue($this->sequenceConfig->get('startValue'))
-                ->setStoreId(1)
-                ->setStep($this->sequenceConfig->get('step'))
-                ->setWarningValue($this->sequenceConfig->get('warningValue'))
-                ->setMaxValue($this->sequenceConfig->get('maxValue'))
-                ->setEntityType($entityType)->create();
-        }
     }
 }

app/code/Magento/Sales/etc/di.xml

@@ -157,4 +157,14 @@
             <argument name="entityGrid" xsi:type="object">Magento\Sales\Model\Resource\Order\Creditmemo\Grid</argument>
         </arguments>
     </virtualType>
+    <type name="Magento\SalesSequence\Model\EntityPool">
+        <arguments>
+            <argument name="entities" xsi:type="array">
+                <item name="order" xsi:type="string">order</item>
+                <item name="invoice" xsi:type="string">invoice</item>
+                <item name="creditmemo" xsi:type="string">creditmemo</item>
+                <item name="shipment" xsi:type="string">shipment</item>
+            </argument>
+        </arguments>
+    </type>
 </config>

app/code/Magento/SalesSequence/Model/EntityPool.php

@@ -0,0 +1,37 @@
+<?php
+/**
+ * Copyright © 2015 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\SalesSequence\Model;
+
+/**
+ * Class EntityPool
+ *
+ * Pool of entities that require sequence
+ */
+class EntityPool
+{
+    /**
+     * @var array
+     */
+    protected $entities;
+
+    /**
+     * @param array $entities
+     */
+    public function __construct(array $entities = [])
+    {
+        $this->entities = $entities;
+    }
+
+    /**
+     * Retrieve entities that require sequence
+     *
+     * @return array
+     */
+    public function getEntities()
+    {
+        return $this->entities;
+    }
+}

app/code/Magento/Sales/Model/Observer/CreateSequence.php renamed to app/code/Magento/SalesSequence/Model/Observer.php

@@ -3,27 +3,24 @@
  * Copyright © 2015 Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Sales\Model\Observer;
+namespace Magento\SalesSequence\Model;
 
-use Magento\Sales\Setup\SalesSetup;
-use Magento\SalesSequence\Model\Config;
-use Magento\SalesSequence\Model\Builder;
-use Magento\Framework\Event\Observer;
+use Magento\Framework\Event\Observer as EventObserver;
 
 /**
  * Class CreateSequence
  */
-class CreateSequence
+class Observer
 {
     /**
      * @var Builder
      */
     private $sequenceBuilder;
 
     /**
-     * @var SalesSetup
+     * @var EntityPool
      */
-    private $salesSetup;
+    private $entityPool;
 
     /**
      * @var Config
@@ -34,28 +31,27 @@ class CreateSequence
      * Initialization
      *
      * @param Builder $sequenceBuilder
-     * @param SalesSetup $salesSetup
+     * @param EntityPool $entityPool
      * @param Config $sequenceConfig
      */
     public function __construct(
         Builder $sequenceBuilder,
-        SalesSetup $salesSetup,
+        EntityPool $entityPool,
         Config $sequenceConfig
     ) {
         $this->sequenceBuilder = $sequenceBuilder;
-        $this->salesSetup = $salesSetup;
+        $this->entityPool = $entityPool;
         $this->sequenceConfig = $sequenceConfig;
     }
 
     /**
-     * @param Observer $observer
+     * @param EventObserver $observer
      * @return $this
      */
-    public function execute(Observer $observer)
+    public function execute(EventObserver $observer)
     {
         $storeId = $observer->getData('store')->getId();
-        $defaultEntities = array_keys($this->salesSetup->getDefaultEntities());
-        foreach ($defaultEntities as $entityType) {
+        foreach ($this->entityPool->getEntities() as $entityType) {
             $this->sequenceBuilder->setPrefix($this->sequenceConfig->get('prefix'))
                 ->setSuffix($this->sequenceConfig->get('suffix'))
                 ->setStartValue($this->sequenceConfig->get('startValue'))

app/code/Magento/SalesSequence/Setup/InstallData.php

@@ -0,0 +1,75 @@
+<?php
+/**
+ * Copyright © 2015 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\SalesSequence\Setup;
+
+use Magento\Framework\Setup\InstallDataInterface;
+use Magento\Framework\Setup\ModuleContextInterface;
+use Magento\Framework\Setup\ModuleDataSetupInterface;
+use Magento\SalesSequence\Model\Builder;
+use Magento\SalesSequence\Model\Config as SequenceConfig;
+use Magento\SalesSequence\Model\EntityPool;
+
+/**
+ * Class InstallData
+ * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+ * @codeCoverageIgnore
+ */
+class InstallData implements InstallDataInterface
+{
+    /**
+     * Sales setup factory
+     *
+     * @var EntityPool
+     */
+    private $entityPool;
+
+    /**
+     * @var Builder
+     */
+    private $sequenceBuilder;
+
+    /**
+     * @var SequenceConfig
+     */
+    private $sequenceConfig;
+
+    /**
+     * @param EntityPool $entityPool
+     * @param Builder $sequenceBuilder
+     * @param SequenceConfig $sequenceConfig
+     */
+    public function __construct(
+        EntityPool $entityPool,
+        Builder $sequenceBuilder,
+        SequenceConfig $sequenceConfig
+    ) {
+        $this->salesSetupFactory = $entityPool;
+        $this->sequenceBuilder = $sequenceBuilder;
+        $this->sequenceConfig = $sequenceConfig;
+    }
+
+    /**
+     * {@inheritdoc}
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     */
+    public function install(ModuleDataSetupInterface $setup, ModuleContextInterface $context)
+    {
+        $defaultStoreIds = [0, 1];
+        foreach ($defaultStoreIds as $storeId) {
+            foreach ($this->entityPool->getEntities() as $entityType) {
+                $this->sequenceBuilder->setPrefix($this->sequenceConfig->get('prefix'))
+                    ->setSuffix($this->sequenceConfig->get('suffix'))
+                    ->setStartValue($this->sequenceConfig->get('startValue'))
+                    ->setStoreId($storeId)
+                    ->setStep($this->sequenceConfig->get('step'))
+                    ->setWarningValue($this->sequenceConfig->get('warningValue'))
+                    ->setMaxValue($this->sequenceConfig->get('maxValue'))
+                    ->setEntityType($entityType)->create();
+            }
+        }
+    }
+}