MAGETWO-44274: SQL error appears if Save & Duplicate product with images

Author: Michail Slabko

app/code/Magento/Catalog/Model/Product/Attribute/Backend/Media.php

@@ -85,7 +85,7 @@ public function beforeSave($object)
             // For duplicating we need copy original images.
             $duplicate = [];
             foreach ($value['images'] as &$image) {
-                if (empty($image['value_id'])) {
+                if (empty($image['value_id']) || !empty($image['removed'])) {
                     continue;
                 }
                 $duplicate[$image['value_id']] = $this->copyImage($image['file']);

app/code/Magento/Catalog/Model/ResourceModel/Product/Attribute/Backend/Media.php

@@ -324,11 +324,12 @@ public function duplicate($attributeId, $newFiles, $originalProductId, $newProdu
         foreach ($this->getConnection()->fetchAll($select) as $row) {
             $data = [
                 'attribute_id' => $attributeId,
-                'entity_id' => $newProductId,
                 'value' => isset($newFiles[$row['value_id']]) ? $newFiles[$row['value_id']] : $row['value'],
             ];
 
             $valueIdMap[$row['value_id']] = $this->insertGallery($data);
+            $this->bindValueToEntity($valueIdMap[$row['value_id']], $newProductId);
+
         }
 
         if (count($valueIdMap) == 0) {
@@ -344,6 +345,8 @@ public function duplicate($attributeId, $newFiles, $originalProductId, $newProdu
         );
 
         foreach ($this->getConnection()->fetchAll($select) as $row) {
+            unset($row['record_id']);
+            $row['entity_id'] = $newProductId;
             $row['value_id'] = $valueIdMap[$row['value_id']];
             $this->insertGalleryValueInStore($row);
         }