MAGETWO-39857: Event 'customer_save_after_data_object' dispatches a few times

Author: AndriyNasinnyk

app/code/Magento/Quote/Test/Unit/Model/Observer/Backend/CustomerQuoteTest.php

@@ -57,7 +57,7 @@ protected function setUp()
             ->getMock();
         $this->eventMock = $this->getMockBuilder('Magento\Framework\Event')
             ->disableOriginalConstructor()
-            ->setMethods(['getOrigCustomerDataObject', 'getCustomerDataObject'])
+            ->setMethods(['getCustomerDataObject'])
             ->getMock();
         $this->observerMock->expects($this->any())->method('getEvent')->will($this->returnValue($this->eventMock));
         $objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
@@ -91,8 +91,9 @@ public function testDispatchNoCustomerGroupChange()
         $this->eventMock->expects($this->any())
             ->method('getOrigCustomerDataObject')
             ->will($this->returnValue($origCustomerDataObjectMock));
-        $this->quoteRepositoryMock->expects($this->never())
-            ->method('getForCustomer');
+        $this->quoteRepositoryMock->expects($this->once())
+            ->method('getForCustomer')
+            ->willThrowException(new \Magento\Framework\Exception\NoSuchEntityException());
 
         $this->customerQuote->dispatch($this->observerMock);
     }
@@ -128,57 +129,38 @@ public function testDispatch($isWebsiteScope, $websites, $quoteId)
                 ->method('getWebsites')
                 ->will($this->returnValue($websites));
         }
-        $origCustomerDataObjectMock = $this->getMockBuilder('Magento\Customer\Api\Data\CustomerInterface')
-            ->disableOriginalConstructor()
-            ->getMock();
-        $origCustomerDataObjectMock->expects($this->any())
-            ->method('getGroupId')
-            ->will($this->returnValue(2));
         $this->eventMock->expects($this->any())
             ->method('getCustomerDataObject')
             ->will($this->returnValue($customerDataObjectMock));
-        $this->eventMock->expects($this->any())
-            ->method('getOrigCustomerDataObject')
-            ->will($this->returnValue($origCustomerDataObjectMock));
         /** @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Quote\Model\Quote $quoteMock */
         $quoteMock = $this->getMockBuilder(
             'Magento\Quote\Model\Quote'
         )->setMethods(
                 [
                     'setWebsite',
                     'setCustomerGroupId',
+                    'getCustomerGroupId',
                     'collectTotals',
                     '__wakeup',
                 ]
             )->disableOriginalConstructor(
             )->getMock();
         $websiteCount = count($websites);
-        if ($quoteId) {
-            $this->quoteRepositoryMock->expects($this->exactly($websiteCount))
-                ->method('getForCustomer')
-                ->will($this->returnValue($quoteMock));
-            $quoteMock->expects($this->exactly($websiteCount))
-                ->method('setWebsite');
-            $quoteMock->expects($this->exactly($websiteCount))
-                ->method('setCustomerGroupId');
-            $quoteMock->expects($this->exactly($websiteCount))
-                ->method('collectTotals');
-            $this->quoteRepositoryMock->expects($this->exactly($websiteCount))
-                ->method('save')
-                ->with($quoteMock);
-        } else {
-            $this->quoteRepositoryMock->expects($this->exactly($websiteCount))
-                ->method('getForCustomer')
-                ->willThrowException(
-                    new \Magento\Framework\Exception\NoSuchEntityException()
-                );
-            $quoteMock->expects($this->never())
-                ->method('setCustomerGroupId');
-            $quoteMock->expects($this->never())
-                ->method('collectTotals');
-            $this->quoteRepositoryMock->expects($this->never())
-                ->method('save');
-        }
+        $this->quoteRepositoryMock->expects($this->once())
+            ->method('getForCustomer')
+            ->will($this->returnValue($quoteMock));
+        $quoteMock->expects($this->exactly($websiteCount))
+            ->method('setWebsite');
+        $quoteMock->expects($this->exactly($websiteCount))
+            ->method('setCustomerGroupId');
+        $quoteMock->expects($this->exactly($websiteCount))
+            ->method('collectTotals');
+        $this->quoteRepositoryMock->expects($this->exactly($websiteCount))
+            ->method('save')
+            ->with($quoteMock);
+        $quoteMock->expects($this->once())
+            ->method('getCustomerGroupId')
+            ->willReturn(2);
         $this->customerQuote->dispatch($this->observerMock);
     }