Skip to content

Commit 8b354bc

Browse files
author
Roman Ganin
committed
MAGETWO-39187: Remove @codingStandardsIgnoreFile directive from code assigned to Troll team
- CR changes
1 parent 507fc72 commit 8b354bc

File tree

24 files changed

+79
-26
lines changed

24 files changed

+79
-26
lines changed

‎app/code/Magento/Reports/Block/Adminhtml/Filter/Form.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,21 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic
1616
/**
1717
* Report type options
1818
*
19-
* @var []
19+
* @var array
2020
*/
2121
protected $_reportTypeOptions = [];
2222

2323
/**
2424
* Report field visibility
2525
*
26-
* @var []
26+
* @var array
2727
*/
2828
protected $_fieldVisibility = [];
2929

3030
/**
3131
* Report field opions
3232
*
33-
* @var []
33+
* @var array
3434
*/
3535
protected $_fieldOptions = [];
3636

@@ -94,6 +94,7 @@ public function setFieldOption($fieldId, $option, $value = null)
9494
* @param string $key
9595
* @param string $value
9696
* @return $this
97+
* @codeCoverageIgnore
9798
*/
9899
public function addReportTypeOption($key, $value)
99100
{

‎app/code/Magento/Reports/Block/Adminhtml/Grid.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ class Grid extends \Magento\Backend\Block\Widget\Grid
3030
/**
3131
* Filters array
3232
*
33-
* @var []
33+
* @var array
3434
*/
3535
protected $_filters = [];
3636

3737
/**
3838
* Default filters values
3939
*
40-
* @var []
40+
* @var array
4141
*/
4242
protected $_defaultFilters = ['report_from' => '', 'report_to' => '', 'report_period' => 'day'];
4343

@@ -51,7 +51,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid
5151
/**
5252
* Errors messages aggregated array
5353
*
54-
* @var []
54+
* @var array
5555
*/
5656
protected $_errors = [];
5757

@@ -65,7 +65,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid
6565
/**
6666
* Filter values array
6767
*
68-
* @var []
68+
* @var array
6969
*/
7070
protected $_filterValues;
7171

@@ -236,10 +236,10 @@ public function getStoreSwitcherHtml()
236236

237237
/**
238238
* Set visibility of date filter
239-
* @codeCoverageIgnore
240239
*
241240
* @param bool $visible
242241
* @return void
242+
* @codeCoverageIgnore
243243
*/
244244
public function setDateFilterVisibility($visible = true)
245245
{
@@ -302,11 +302,11 @@ public function getRefreshButtonHtml()
302302

303303
/**
304304
* Set filter
305-
* @codeCoverageIgnore
306305
*
307306
* @param string $name
308307
* @param string $value
309308
* @return void
309+
* @codeCoverageIgnore
310310
*/
311311
public function setFilter($name, $value)
312312
{
@@ -332,10 +332,10 @@ public function getFilter($name)
332332

333333
/**
334334
* Set sub-report rows count
335-
* @codeCoverageIgnore
336335
*
337336
* @param int $size
338337
* @return void
338+
* @codeCoverageIgnore
339339
*/
340340
public function setSubReportSize($size)
341341
{
@@ -355,9 +355,9 @@ public function getSubReportSize()
355355

356356
/**
357357
* Retrieve errors
358-
* @codeCoverageIgnore
359358
*
360359
* @return array
360+
* @codeCoverageIgnore
361361
*/
362362
public function getErrors()
363363
{

‎app/code/Magento/Reports/Block/Adminhtml/Grid/AbstractGrid.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,10 +346,10 @@ public function getSubTotals()
346346

347347
/**
348348
* StoreIds setter
349-
* @codeCoverageIgnore
350349
*
351350
* @param array $storeIds
352351
* @return $this
352+
* @codeCoverageIgnore
353353
*/
354354
public function setStoreIds($storeIds)
355355
{
@@ -404,6 +404,7 @@ protected function _addOrderStatusFilter($collection, $filterData)
404404
* @param \Magento\Framework\Object $filterData
405405
* @return $this
406406
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
407+
* @codeCoverageIgnore
407408
*/
408409
protected function _addCustomFilter($collection, $filterData)
409410
{

‎app/code/Magento/Reports/Block/Adminhtml/Product.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
class Product extends \Magento\Backend\Block\Widget\Grid\Container
1414
{
1515
/**
16-
* @return void
16+
* {@inheritdoc}
1717
*/
1818
protected function _construct()
1919
{

‎app/code/Magento/Reports/Block/Adminhtml/Sales/Bestsellers.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,14 @@
1313
class Bestsellers extends \Magento\Backend\Block\Widget\Grid\Container
1414
{
1515
/**
16+
* Template
17+
*
1618
* @var string
1719
*/
1820
protected $_template = 'report/grid/container.phtml';
1921

2022
/**
21-
* @return void
23+
* {@inheritdoc}
2224
*/
2325
protected function _construct()
2426
{
@@ -35,6 +37,8 @@ protected function _construct()
3537
}
3638

3739
/**
40+
* Get filter URL
41+
*
3842
* @return string
3943
*/
4044
public function getFilterUrl()

‎app/code/Magento/Reports/Block/Adminhtml/Sales/Bestsellers/Grid.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,15 @@
1414
class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid
1515
{
1616
/**
17+
* GROUP BY criteria
18+
*
1719
* @var string
1820
*/
1921
protected $_columnGroupBy = 'period';
2022

2123
/**
22-
* @return void
24+
* {@inheritdoc}
25+
* @codeCoverageIgnore
2326
*/
2427
protected function _construct()
2528
{
@@ -28,15 +31,16 @@ protected function _construct()
2831
}
2932

3033
/**
31-
* @return string
34+
* {@inheritdoc}
35+
* @codeCoverageIgnore
3236
*/
3337
public function getResourceCollectionName()
3438
{
3539
return 'Magento\Sales\Model\Resource\Report\Bestsellers\Collection';
3640
}
3741

3842
/**
39-
* @return \Magento\Backend\Block\Widget\Grid\Extended
43+
* {@inheritdoc}
4044
*/
4145
protected function _prepareColumns()
4246
{

‎app/code/Magento/Reports/Block/Adminhtml/Sales/Coupons.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,14 @@
1313
class Coupons extends \Magento\Backend\Block\Widget\Grid\Container
1414
{
1515
/**
16+
* Template file
17+
*
1618
* @var string
1719
*/
1820
protected $_template = 'report/grid/container.phtml';
1921

2022
/**
21-
* @return void
23+
* {@inheritdoc}
2224
*/
2325
protected function _construct()
2426
{
@@ -35,6 +37,8 @@ protected function _construct()
3537
}
3638

3739
/**
40+
* Get filter URL
41+
*
3842
* @return string
3943
*/
4044
public function getFilterUrl()

‎app/code/Magento/Reports/Block/Adminhtml/Sales/Coupons/Grid.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,15 @@
1414
class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid
1515
{
1616
/**
17+
* GROUP BY criteria
18+
*
1719
* @var string
1820
*/
1921
protected $_columnGroupBy = 'period';
2022

2123
/**
22-
* @return void
24+
* {@inheritdoc}
25+
* @codeCoverageIgnore
2326
*/
2427
protected function _construct()
2528
{
@@ -29,7 +32,7 @@ protected function _construct()
2932
}
3033

3134
/**
32-
* @return string
35+
* {@inheritdoc}
3336
*/
3437
public function getResourceCollectionName()
3538
{
@@ -41,7 +44,7 @@ public function getResourceCollectionName()
4144
}
4245

4346
/**
44-
* @return \Magento\Backend\Block\Widget\Grid\Extended
47+
* {@inheritdoc}
4548
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
4649
*/
4750
protected function _prepareColumns()

‎app/code/Magento/Reports/Block/Adminhtml/Sales/Grid/Column/Renderer/Date.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
class Date extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Date
1414
{
1515
/**
16+
* Constructor
17+
*
1618
* @param \Magento\Backend\Block\Context $context
1719
* @param \Magento\Framework\Locale\ResolverInterface $localeResolver
1820
* @param array $data

‎app/code/Magento/Reports/Block/Adminhtml/Sales/Invoiced.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,14 @@
1313
class Invoiced extends \Magento\Backend\Block\Widget\Grid\Container
1414
{
1515
/**
16+
* Template file
17+
*
1618
* @var string
1719
*/
1820
protected $_template = 'report/grid/container.phtml';
1921

2022
/**
21-
* @return void
23+
* {@inheritdoc}
2224
*/
2325
protected function _construct()
2426
{
@@ -35,6 +37,8 @@ protected function _construct()
3537
}
3638

3739
/**
40+
* Get filter URL
41+
*
3842
* @return string
3943
*/
4044
public function getFilterUrl()

0 commit comments

Comments
 (0)