Remove direct server variable use

Dominic · Dominic · commit 8af727d6fffc · 2019-02-04T20:05:00.000+05:30
diff --git a/app/code/Magento/Store/Model/Store.php b/app/code/Magento/Store/Model/Store.php
@@ -707,7 +707,8 @@ protected function _updatePathUseRewrites($url)
             if ($this->_isCustomEntryPoint()) {
                 $indexFileName = 'index.php';
             } else {
-                $indexFileName = basename($_SERVER['SCRIPT_FILENAME']);
+                $scriptFilename = $this->_request->getServer('SCRIPT_FILENAME');
+                $indexFileName = basename($scriptFilename);
             }
             $url .= $indexFileName . '/';
         }

Original file line number	Diff line number	Diff line change
`@@ -707,7 +707,8 @@ protected function _updatePathUseRewrites($url)`
`707`	`707`	`if ($this->_isCustomEntryPoint()) {`
`708`	`708`	`$indexFileName = 'index.php';`
`709`	`709`	`} else {`
`710`		`- $indexFileName = basename($_SERVER['SCRIPT_FILENAME']);`
	`710`	`+ $scriptFilename = $this->_request->getServer('SCRIPT_FILENAME');`
	`711`	`+ $indexFileName = basename($scriptFilename);`
`711`	`712`	`}`
`712`	`713`	`$url .= $indexFileName . '/';`
`713`	`714`	`}`