Skip to content

Commit 8ad979e

Browse files
Dmytro VilchynskyiNatalia Momotenko
authored andcommitted
MAGETWO-46821: Update readable content
- fix fails on Bamboo
1 parent 8547952 commit 8ad979e

File tree

3 files changed

+6
-4
lines changed
  • app/code/Magento/Ui/view/base/web/templates/grid/cells
  • dev/tests
    • functional/tests/app/Magento/Cms/Test/Block/Adminhtml/Page
    • integration/testsuite/Magento/CurrencySymbol/Controller/Adminhtml/System/Currency

3 files changed

+6
-4
lines changed

app/code/Magento/Ui/view/base/web/templates/grid/cells/actions.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<button class="action-select" translate="'Select'" toggleCollapsible/>
1717
<ul class="action-menu" css="_active: $collapsible.opened">
1818
<li repeat="foreach: $col.getVisibleActions($row()._rowIndex), item: '$action'">
19-
<a class="action-menu-item" click="$col.getActionHandler($action())" text="$action().label" attr="href: $action().href"/>
19+
<a class="action-menu-item" click="$col.getActionHandler($action())" text="$action().label" attr="href: $action().href, 'data-action': 'item-' + $action().index"/>
2020
</li>
2121
</ul>
2222
</div>

dev/tests/functional/tests/app/Magento/Cms/Test/Block/Adminhtml/Page/Grid.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class Grid extends DataGrid
7373
*
7474
* @var string
7575
*/
76-
protected $previewCmsPage = "..//a[contains(@class, 'action-menu-item') and text() = 'Preview']";
76+
protected $previewCmsPage = '[data-action="item-preview"]';
7777

7878
/**
7979
* Click on "Edit" link.
@@ -100,7 +100,7 @@ public function searchAndPreview(array $filter)
100100
$rowItem = $this->getRow([$filter['title']]);
101101
if ($rowItem->isVisible()) {
102102
$rowItem->find($this->selectAction)->click();
103-
$rowItem->find($this->previewCmsPage, Locator::SELECTOR_XPATH)->click();
103+
$rowItem->find($this->previewCmsPage)->click();
104104
} else {
105105
throw new \Exception('Searched item was not found.');
106106
}

dev/tests/integration/testsuite/Magento/CurrencySymbol/Controller/Adminhtml/System/Currency/SaveRatesTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,9 @@ public function testSaveWithWarningAction()
8484
$this->dispatch('backend/admin/system_currency/saveRates');
8585

8686
$this->assertSessionMessages(
87-
$this->contains((string)__('Please correct the input data for "%1 => %2" rate.', $currencyCode, $currencyTo)),
87+
$this->contains(
88+
(string)__('Please correct the input data for "%1 => %2" rate.', $currencyCode, $currencyTo)
89+
),
8890
\Magento\Framework\Message\MessageInterface::TYPE_WARNING
8991
);
9092
}

0 commit comments

Comments
 (0)