Skip to content

Commit 8a5707a

Browse files
committed
[ACQE-7280] To check whether admin is able to change the frontend logo when single store mode is enabled in the configuration.
fixed code review comments
1 parent ee610ab commit 8a5707a

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

app/code/Magento/Theme/Test/Mftf/Test/ChangeFrontendLogoWithSingleStoreModeTest.xml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,9 @@
3838
</after>
3939
<amOnPage url="{{DesignConfigPage.url}}" stepKey="navigateToDesignConfigPage" />
4040
<waitForPageLoad stepKey="waitForDesignConfigPageLoad"/>
41+
<waitForElementClickable selector="{{AdminDesignConfigSection.scopeRow('3')}}" stepKey="waitForScopeRowClickable"/>
4142
<click selector="{{AdminDesignConfigSection.scopeRow('3')}}" stepKey="editStoreView"/>
42-
<waitForPageLoad stepKey="waitForAdminDesignConfigSectionPageLoad"/>
43+
<waitForElementVisible selector="{{AdminDesignConfigSection.headerSection}}" stepKey="waitForAdminDesignConfigHeaderSectionVisible"/>
4344
<scrollTo selector="{{AdminDesignConfigSection.headerSection}}" stepKey="scrollToHtmlHeadSection"/>
4445
<click selector="{{AdminDesignConfigSection.headerSection}}" stepKey="openHtmlHeadSection"/>
4546
<!--Upload the First Image-->
@@ -61,7 +62,6 @@
6162
<actionGroup ref="SaveImageActionGroup" stepKey="insertImage"/>
6263
<click selector="{{AdminDesignConfigSection.saveConfiguration}}" stepKey="saveConfiguration"/>
6364
<waitForElementVisible selector="{{AdminDesignConfigSection.successNotification}}" stepKey="waitForSuccessNotification"/>
64-
<waitForPageLoad stepKey="waitForPageLoadSuccess"/>
6565
<!--Clear Cache-->
6666
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterFirstImageUpload">
6767
<argument name="tags" value=""/>
@@ -70,8 +70,8 @@
7070
<actionGroup ref="StorefrontOpenHomePageActionGroup" stepKey="goToHomePage"/>
7171
<waitForPageLoad stepKey="waitToLoadHomePage"/>
7272
<!--assert to check first uploaded image name-->
73-
<seeElementInDOM selector="{{StorefrontHeaderSection.logoImage(ImageUpload3.fileName)}}" stepKey="assertMediaSource"/>
74-
<!-- Enable Single Store Mode -->
73+
<waitForElement selector="{{StorefrontHeaderSection.logoImage(ImageUpload3.fileName)}}" stepKey="waitForLogoImageVisible"/>
74+
<!-- Enable Single Store Mode -->
7575
<magentoCLI command="config:set general/single_store_mode/enabled 1" stepKey="enabledSingleStoreMode"/>
7676
<!--Clear Cache-->
7777
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterSingleStoreModeEnabled">
@@ -103,7 +103,6 @@
103103
<actionGroup ref="SaveImageActionGroup" stepKey="insertSecondImage"/>
104104
<click selector="{{AdminDesignConfigSection.saveConfiguration}}" stepKey="saveConfigurationForSecondImage"/>
105105
<waitForElementVisible selector="{{AdminDesignConfigSection.successNotification}}" stepKey="waitForSuccessNotificationForSecondImage"/>
106-
<waitForPageLoad stepKey="waitForPageLoadSuccessForSecondImage"/>
107106
<!--Clear Cache-->
108107
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterSecondImageUpload">
109108
<argument name="tags" value=""/>
@@ -112,10 +111,10 @@
112111
<actionGroup ref="StorefrontOpenHomePageActionGroup" stepKey="goToStoreFrontHomePage"/>
113112
<waitForPageLoad stepKey="waitToLoadStoreFrontHomePage"/>
114113
<!--assert to check second uploaded image name-->
115-
<seeElementInDOM selector="{{StorefrontHeaderSection.logoImage(ImageUpload.fileName)}}" stepKey="assertUploadedImage"/>
114+
<waitForElement selector="{{StorefrontHeaderSection.logoImage(ImageUpload.fileName)}}" stepKey="waitForSecondLogoImageVisible"/>
116115
<!--Navigate to Store View to delete uploaded logo-->
117116
<amOnPage url="{{DesignConfigPage.url}}" stepKey="navigateToDesignConfigPageToDeleteUploadedLogo"/>
118-
<waitForPageLoad stepKey="waitForNavigateDesignConfigPageLoad"/>
117+
<waitForElementClickable selector="{{AdminDesignConfigSection.scopeRow('1')}}" stepKey="waitForScopeRow1Clickable"/>
119118
<click selector="{{AdminDesignConfigSection.scopeRow('1')}}" stepKey="editStoreViewForScopeRow"/>
120119
<waitForPageLoad stepKey="waitForPageLoadAfterSelectingScopeRow"/>
121120
<scrollTo selector="{{AdminDesignConfigSection.headerSection}}" stepKey="scrollToHtmlHeadSectionToDeleteImage"/>

0 commit comments

Comments
 (0)