MAGETWO-71515: Special/lowest price in child of a Configurable Product causes the entire product to show that price

- FAT

Author: Dmytro Vilchynskyi

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/Compare/ListCompare.php

@@ -16,6 +16,13 @@
  */
 class ListCompare extends Block
 {
+    /**
+     * Price displaying format.
+     *
+     * @var int
+     */
+    protected $priceFormat = 2;
+
     /**
      * Selector by product info.
      *
@@ -101,11 +108,7 @@ public function getProductInfo($index, $attributeKey, $currency = ' $')
             $price = $infoBlock->find($this->priceSelector, Locator::SELECTOR_XPATH)->getText();
             preg_match_all('`([a-z]+).*?([\d\.]+)`i', $price, $prices);
             if (!empty($prices[0])) {
-                $resultPrice = [];
-                foreach ($prices[1] as $key => $value) {
-                    $resultPrice['price_' . lcfirst($value)] = $prices[2][$key];
-                }
-                return $resultPrice;
+                return number_format(end($prices)[0], $this->priceFormat);
             }
             return trim($price, $currency);
         } else {

dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductComparePage.php

@@ -16,6 +16,13 @@
  */
 class AssertProductComparePage extends AbstractConstraint
 {
+    /**
+     * Price displaying format.
+     *
+     * @var int
+     */
+    protected $priceFormat = 2;
+
     /**
      * Product attribute on compare product page
      *
@@ -30,8 +37,8 @@ class AssertProductComparePage extends AbstractConstraint
     ];
 
     /**
-     * Assert that "Compare Product" page contains product(s) that was added
-     * - Product name
+     * Assert that "Compare Product" Storefront page contains added Products with expected Attribute values:
+     * - Name
      * - Price
      * - SKU
      * - Description (if exists, else text "No")
@@ -56,19 +63,23 @@ public function processAssert(
                 $value = $attribute;
                 $attribute = is_numeric($attributeKey) ? $attribute : $attributeKey;
 
-                $attributeValue = $attribute != 'price'
+                $expectedAttributeValue = $attribute != 'price'
                     ? ($product->hasData($attribute)
                         ? $product->getData($attribute)
                         : 'N/A')
                     : ($product->getDataFieldConfig('price')['source']->getPriceData() !== null
                         ? $product->getDataFieldConfig('price')['source']->getPriceData()['compare_price']
-                        : number_format($product->getPrice(), 2));
+                        : number_format($product->getPrice(), $this->priceFormat));
 
                 $attribute = is_numeric($attributeKey) ? 'info' : 'attribute';
+                $attribute = ucfirst($attribute);
+                $actualAttributeValue =
+                    $comparePage->getCompareProductsBlock()->{'getProduct' . $attribute}($key + 1, $value);
+
                 \PHPUnit_Framework_Assert::assertEquals(
-                    $attributeValue,
-                    $comparePage->getCompareProductsBlock()->{'getProduct' . ucfirst($attribute)}($key + 1, $value),
-                    'Product "' . $product->getName() . '" is\'n equals with data from fixture.'
+                    $expectedAttributeValue,
+                    $actualAttributeValue,
+                    'Product "' . $product->getName() . '" has "' . $attribute . '" value different from fixture one.'
                 );
             }
         }

dev/tests/functional/tests/app/Magento/ConfigurableProduct/Test/Repository/ConfigurableProduct/Price.xml

@@ -12,14 +12,14 @@
         </dataset>
         <dataset name="price_40">
             <field name="category_price" xsi:type="string">40</field>
-            <field name="compare_price" xsi:type="string">40</field>
+            <field name="compare_price" xsi:type="string">40.00</field>
         </dataset>
         <dataset name="MAGETWO-12620">
             <field name="category_price" xsi:type="string">11</field>
         </dataset>
         <dataset name="price_15">
             <field name="category_price" xsi:type="string">15</field>
-            <field name="compare_price" xsi:type="string">15</field>
+            <field name="compare_price" xsi:type="string">15.00</field>
         </dataset>
     </repository>
 </config>