Skip to content

Commit 895a765

Browse files
committed
Merge branch 'ACP2E-3672' of https://github.com/adobe-commerce-tier-4/magento2ce into PR-02-11-2025
2 parents 80899e5 + a9be930 commit 895a765

File tree

7 files changed

+67
-47
lines changed

7 files changed

+67
-47
lines changed

app/code/Magento/Csp/Test/Unit/Plugin/StoreAssetIntegrityHashesTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2024 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

@@ -62,7 +62,6 @@ protected function setUp(): void
6262
* Test After Deploy method of plugin
6363
*
6464
* @return void
65-
* @doesNotPerformAssertions
6665
*/
6766
public function testAfterDeploy(): void
6867
{

app/code/Magento/Customer/Test/Unit/Model/AccountManagementApiTest.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2023 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

@@ -433,8 +433,6 @@ public function testBeforeCreateAccount(
433433
): void {
434434
if ($willThrowException) {
435435
$this->expectException(AuthorizationException::class);
436-
} else {
437-
$this->expectNotToPerformAssertions();
438436
}
439437
$this->authorizationMock
440438
->expects($this->once())

app/code/Magento/Customer/Test/Unit/Plugin/AsyncRequestCustomerGroupAuthorizationTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2023 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

@@ -86,7 +86,6 @@ public function testBeforePublishMass(
8686
[$customer, 'Password1', '']
8787
];
8888
$this->authorizationMock
89-
->expects($this->once())
9089
->method('isAllowed')
9190
->with('Magento_Customer::manage')
9291
->willReturn($isAllowed);

app/code/Magento/Swagger/Test/Unit/Controller/Index/IndexTest.php

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
2-
/***
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
2+
/**
3+
* Copyright 2015 Adobe
4+
* All Rights Reserved.
55
*/
66

77
declare(strict_types=1);
@@ -67,9 +67,10 @@ protected function setUp(): void
6767
}
6868

6969
/**
70-
* @doesNotPerformAssertions
70+
* @return void
71+
* @throws NotFoundException
7172
*/
72-
public function testExecute()
73+
public function testExecute(): void
7374
{
7475
$this->pageConfigMock->expects($this->once())
7576
->method('addBodyClass')
@@ -95,9 +96,10 @@ public function testDispatchRejectsWhenDisabled()
9596
}
9697

9798
/**
98-
* @doesNotPerformAssertions
99+
* @return void
100+
* @throws NotFoundException
99101
*/
100-
public function testDispatchIsSuccessfulWhenEnabled()
102+
public function testDispatchIsSuccessfulWhenEnabled(): void
101103
{
102104
$request = self::getMockBuilder(Http::class)
103105
->disableOriginalConstructor()

lib/internal/Magento/Framework/Webapi/Test/Unit/InputLimit/DefaultPageSizeSetterTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2021 Adobe
4+
* All Rights Reserved.
55
*/
66

77
declare(strict_types=1);
@@ -38,9 +38,9 @@ protected function setUp(): void
3838
}
3939

4040
/**
41-
* @doesNotPerformAssertions
41+
* @return void
4242
*/
43-
public function testPageSizeIsNotSetWhenLimitingIsDisabled()
43+
public function testPageSizeIsNotSetWhenLimitingIsDisabled(): void
4444
{
4545
$this->configProvider->method('isInputLimitingEnabled')
4646
->willReturn(false);
@@ -55,9 +55,9 @@ public function testPageSizeIsNotSetWhenLimitingIsDisabled()
5555
}
5656

5757
/**
58-
* @doesNotPerformAssertions
58+
* @return void
5959
*/
60-
public function testPageSizeIsNotSetWhenAlreadySet()
60+
public function testPageSizeIsNotSetWhenAlreadySet(): void
6161
{
6262
$this->configProvider->method('isInputLimitingEnabled')
6363
->willReturn(true);
@@ -72,9 +72,9 @@ public function testPageSizeIsNotSetWhenAlreadySet()
7272
}
7373

7474
/**
75-
* @doesNotPerformAssertions
75+
* @return void
7676
*/
77-
public function testPageSizeIsSetWithPreferredConfigValue()
77+
public function testPageSizeIsSetWithPreferredConfigValue(): void
7878
{
7979
$this->configProvider->method('isInputLimitingEnabled')
8080
->willReturn(true);
@@ -93,9 +93,9 @@ public function testPageSizeIsSetWithPreferredConfigValue()
9393
}
9494

9595
/**
96-
* @doesNotPerformAssertions
96+
* @return void
9797
*/
98-
public function testPageSizeIsSetWithPreferredFallbackValue()
98+
public function testPageSizeIsSetWithPreferredFallbackValue(): void
9999
{
100100
$this->configProvider->method('isInputLimitingEnabled')
101101
->willReturn(true);

lib/internal/Magento/Framework/Webapi/Test/Unit/ServiceInputProcessorTest.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2014 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

@@ -415,9 +415,10 @@ public function testArrayOfDataObjectPropertiesIsValidated()
415415
}
416416

417417
/**
418-
* @doesNotPerformAssertions
418+
* @return void
419+
* @throws Exception
419420
*/
420-
public function testDefaultPageSizeSetterIsInvoked()
421+
public function testDefaultPageSizeSetterIsInvoked(): void
421422
{
422423
$this->defaultPageSizeSetter->expects(self::once())
423424
->method('processSearchCriteria')

lib/internal/Magento/Framework/Webapi/Test/Unit/Validator/EntityArrayValidatorTest.php

Lines changed: 37 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2021 Adobe
4+
* All Rights Reserved.
55
*/
66

77
declare(strict_types=1);
@@ -50,9 +50,12 @@ protected function setUp(): void
5050
}
5151

5252
/**
53-
* @doesNotPerformAssertions
53+
* @return void
54+
* @throws InvalidArgumentException
55+
* @throws \Magento\Framework\Exception\FileSystemException
56+
* @throws \Magento\Framework\Exception\RuntimeException
5457
*/
55-
public function testAllowsDataWhenBelowLimitWhenUsingRouteInputLimit()
58+
public function testAllowsDataWhenBelowLimitWhenUsingRouteInputLimit(): void
5659
{
5760
$this->configMock->expects(self::once())
5861
->method('isInputLimitingEnabled')
@@ -66,9 +69,12 @@ public function testAllowsDataWhenBelowLimitWhenUsingRouteInputLimit()
6669
}
6770

6871
/**
69-
* @doesNotPerformAssertions
72+
* @return void
73+
* @throws InvalidArgumentException
74+
* @throws \Magento\Framework\Exception\FileSystemException
75+
* @throws \Magento\Framework\Exception\RuntimeException
7076
*/
71-
public function testFailsDataWhenAboveLimitUsingRouteInputLimit()
77+
public function testFailsDataWhenAboveLimitUsingRouteInputLimit(): void
7278
{
7379
$this->expectException(InvalidArgumentException::class);
7480
$this->expectExceptionMessage('Maximum items of type "foo" is 4');
@@ -84,9 +90,12 @@ public function testFailsDataWhenAboveLimitUsingRouteInputLimit()
8490
}
8591

8692
/**
87-
* @doesNotPerformAssertions
93+
* @return void
94+
* @throws InvalidArgumentException
95+
* @throws \Magento\Framework\Exception\FileSystemException
96+
* @throws \Magento\Framework\Exception\RuntimeException
8897
*/
89-
public function testAllowsDataWhenBelowLimit()
98+
public function testAllowsDataWhenBelowLimit(): void
9099
{
91100
$this->configMock->expects(self::once())
92101
->method('isInputLimitingEnabled')
@@ -101,9 +110,12 @@ public function testAllowsDataWhenBelowLimit()
101110
}
102111

103112
/**
104-
* @doesNotPerformAssertions
113+
* @return void
114+
* @throws InvalidArgumentException
115+
* @throws \Magento\Framework\Exception\FileSystemException
116+
* @throws \Magento\Framework\Exception\RuntimeException
105117
*/
106-
public function testAllowsDataWhenBelowLimitUsingConfig()
118+
public function testAllowsDataWhenBelowLimitUsingConfig(): void
107119
{
108120
$this->configMock->expects(self::once())
109121
->method('isInputLimitingEnabled')
@@ -118,9 +130,12 @@ public function testAllowsDataWhenBelowLimitUsingConfig()
118130
}
119131

120132
/**
121-
* @doesNotPerformAssertions
133+
* @return void
134+
* @throws InvalidArgumentException
135+
* @throws \Magento\Framework\Exception\FileSystemException
136+
* @throws \Magento\Framework\Exception\RuntimeException
122137
*/
123-
public function testFailsDataWhenAboveLimit()
138+
public function testFailsDataWhenAboveLimit(): void
124139
{
125140
$this->expectException(InvalidArgumentException::class);
126141
$this->expectExceptionMessage('Maximum items of type "foo" is 3');
@@ -137,9 +152,12 @@ public function testFailsDataWhenAboveLimit()
137152
}
138153

139154
/**
140-
* @doesNotPerformAssertions
155+
* @return void
156+
* @throws InvalidArgumentException
157+
* @throws \Magento\Framework\Exception\FileSystemException
158+
* @throws \Magento\Framework\Exception\RuntimeException
141159
*/
142-
public function testFailsDataWhenAboveLimitUsingConfig()
160+
public function testFailsDataWhenAboveLimitUsingConfig(): void
143161
{
144162
$this->expectException(InvalidArgumentException::class);
145163
$this->expectExceptionMessage('Maximum items of type "foo" is 6');
@@ -156,9 +174,12 @@ public function testFailsDataWhenAboveLimitUsingConfig()
156174
}
157175

158176
/**
159-
* @doesNotPerformAssertions
177+
* @return void
178+
* @throws InvalidArgumentException
179+
* @throws \Magento\Framework\Exception\FileSystemException
180+
* @throws \Magento\Framework\Exception\RuntimeException
160181
*/
161-
public function testAboveLimitWithDisabledLimiting()
182+
public function testAboveLimitWithDisabledLimiting(): void
162183
{
163184
$this->configMock->expects(self::once())
164185
->method('isInputLimitingEnabled')

0 commit comments

Comments
 (0)