Skip to content

Commit 894b31b

Browse files
committed
MAGETWO-55252: Stabilization
- Fix bug with localstorage reset
1 parent f5f603f commit 894b31b

File tree

5 files changed

+17
-5
lines changed

5 files changed

+17
-5
lines changed

dev/tests/functional/tests/app/Magento/Setup/Test/Block/Extension/Grid.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ public function findExtensionOnGrid(Extension $extension)
133133
$this->_rootElement->waitUntil(
134134
function () {
135135
//TODO: Sleep will be removed after MAGETWO-52137
136-
sleep(5);
136+
sleep(10);
137137
$message = $this->_rootElement->find($this->notFoundMessage)->isVisible();
138138
$grid = $this->_rootElement->find($this->dataGrid)->isVisible();
139139

setup/pub/magento/setup/extension-grid.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ angular.module('extension-grid', ['ngStorage'])
129129
version: $scope.availableUpdatePackages[extension.name]['latestVersion']
130130
}
131131
];
132-
titleService.setTitle('uninstall', extension.moduleName ? extension.moduleName : extension.name);
132+
titleService.setTitle('update', extension.moduleName ? extension.moduleName : extension.name);
133133
$state.go('root.readiness-check-update');
134134
};
135135

setup/pub/magento/setup/updater-success.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
'use strict';
77
angular.module('updater-success', ['ngStorage'])
8-
.controller('updaterSuccessController', ['$scope', '$state', '$localStorage', '$window', function ($scope, $state, $localStorage, $window) {
8+
.controller('updaterSuccessController', ['$scope', '$state', '$localStorage', '$window', 'navigationService', function ($scope, $state, $localStorage, $window, navigationService) {
99
if ($localStorage.successPageAction) {
1010
$scope.successPageAction = $localStorage.successPageAction;
1111
$scope.successPageActionMessage = $scope.successPageAction +
@@ -25,4 +25,8 @@ angular.module('updater-success', ['ngStorage'])
2525
}
2626
};
2727
$localStorage.$reset();
28+
$scope.isHiddenSpinner = false;
29+
navigationService.load().then(function () {
30+
$scope.isHiddenSpinner = true;
31+
});
2832
}]);

setup/view/magento/setup/extension-grid.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464

6565
<div class="row" ng-show="$root.isMarketplaceAuthorized && extensionsProcessed && total == 0">
6666
<label class="form-label not-found">
67-
<b>We didn't find any extensions to update at this time. Please try later.</b><br/>
67+
<b>You haven't purchased any extensions yet. Visit <a href="https://marketplace.magento.com">Marketplace</a> for purchasing extensions.</b><br/>
6868
</label>
6969
</div>
7070
<div class="admin__data-grid-outer-wrap" ng-show="$root.isMarketplaceAuthorized && extensionsProcessed && total > 0">

setup/view/magento/setup/updater-success.phtml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,12 @@
2626
ng-click="back()"
2727
type="button"
2828
>Back to Setup Tool</button>
29-
</div>
29+
</div>
30+
<div ng-show="!isHiddenSpinner" class="loading-mask ng-scope" data-role="loader">
31+
<div class="popup popup-loading">
32+
<div class="popup-inner">
33+
<img alt="Loading..." src="<?php echo $this->basePath() ?>/pub/images/loader-1.gif">
34+
Please wait...
35+
</div>
36+
</div>
37+
</div>

0 commit comments

Comments
 (0)