Backport of PR-10445 for Magento 2.1: Fix JS translation search

Don't only replace \' but also \" with ' and "

(cherry picked from commit a150d24)

Concatenate JS translations before translating them

This enables support for $.mage.__("concatenating" + "strings");

(cherry picked from commit c79b583)

+: put all regexes in cdata tags

(cherry picked from commit f930471)

Prevent translation string lookup from breaking on \' or \" with a negative lookbehind

(cherry picked from commit 87d4ba4)

Support $.mage.__('') as well as jQuery.mage.__('')

(cherry picked from commit 5ae47df)

Author: Anton Evers

app/code/Magento/Translation/Model/Js/DataProvider.php

@@ -124,12 +124,13 @@ protected function getPhrases($content)
     {
         $phrases = [];
         foreach ($this->config->getPatterns() as $pattern) {
-            $result = preg_match_all($pattern, $content, $matches);
+            $concatenatedContent = preg_replace('~(["\'])\s*?\+\s*?\1~', '', $content);
+            $result = preg_match_all($pattern, $concatenatedContent, $matches);
 
             if ($result) {
                 if (isset($matches[2])) {
                     foreach ($matches[2] as $match) {
-                        $phrases[] = str_replace('\\\'', '\'', $match);
+                        $phrases[] = str_replace(["\'", '\"'], ["'", '"'], $match);
                     }
                 }
             }

app/code/Magento/Translation/etc/di.xml

@@ -59,8 +59,8 @@
             <argument name="patterns" xsi:type="array">
                 <item name="i18n_translation" xsi:type="string"><![CDATA[~i18n\:\s*(["'])(.*?)(?<!\\)\1~]]></item>
                 <item name="translate_wrapping" xsi:type="string"><![CDATA[~translate\=("')([^\'].*?)\'\"~]]></item>
-                <item name="mage_translation_widget" xsi:type="string">~\$\.mage\.__\((?s)[^'"]*?(['"])(.+?)\1(?s).*?\)~</item>
-                <item name="mage_translation_static" xsi:type="string">~\$t\((?s)[^'"]*?(["'])(.+?)\1(?s).*?\)~</item>
+                <item name="mage_translation_widget" xsi:type="string"><![CDATA[~(?:\$|jQuery)\.mage\.__\((?s)[^'"]*?(['"])(.+?)(?<!\\)\1(?s).*?\)~]]></item>
+                <item name="mage_translation_static" xsi:type="string"><![CDATA[~\$t\((?s)[^'"]*?(["'])(.+?)\1(?s).*?\)~]]></item>
             </argument>
         </arguments>
     </type>