ACP2E-2129: customer is reporting their table rates are not updating via CSV any longer

aplapana · aplapana · commit 89293bbe85f7 · 2023-08-04T10:29:09.000+03:00
- addressed static report
diff --git a/app/code/Magento/OfflineShipping/Model/ResourceModel/Carrier/Tablerate.php b/app/code/Magento/OfflineShipping/Model/ResourceModel/Carrier/Tablerate.php
@@ -296,7 +296,6 @@ private function importData(array $fields, array $values)
      * @todo: this method should be refactored as soon as updated design will be provided
      * @see https://wiki.corp.x.com/display/MCOMS/Magento+Filesystem+Decisions
      */
-    // @phpstan-ignore missingType.return
     public function uploadAndImport(DataObject $object)
     {
         $filePath = $this->getFilePath($object);
@@ -336,6 +335,8 @@ public function uploadAndImport(DataObject $object)
             );
             throw new LocalizedException($error);
         }
+
+        return $this;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,6 @@ private function importData(array $fields, array $values)`
`296`	`296`	`* @todo: this method should be refactored as soon as updated design will be provided`
`297`	`297`	`* @see https://wiki.corp.x.com/display/MCOMS/Magento+Filesystem+Decisions`
`298`	`298`	`*/`
`299`		`- // @phpstan-ignore missingType.return`
`300`	`299`	`public function uploadAndImport(DataObject $object)`
`301`	`300`	`{`
`302`	`301`	`$filePath = $this->getFilePath($object);`
`@@ -336,6 +335,8 @@ public function uploadAndImport(DataObject $object)`
`336`	`335`	`);`
`337`	`336`	`throw new LocalizedException($error);`
`338`	`337`	`}`
	`338`	`+`
	`339`	`+ return $this;`
`339`	`340`	`}`
`340`	`341`
`341`	`342`	`/**`