Skip to content

Commit 88ff702

Browse files
committed
MC-16723: Cannot Create Or Edit Catalog Price Rule or Cart Price Rule
1 parent ce9b748 commit 88ff702

File tree

4 files changed

+1
-51
lines changed

4 files changed

+1
-51
lines changed

dev/tests/integration/testsuite/Magento/Framework/Search/_files/search_request_merged.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
'match_query' => [
3636
'value' => '$match_term_override$',
3737
'name' => 'match_query',
38-
'boost' => '1',
3938
'match' => [
4039
0 => [
4140
'field' => 'match_field',
@@ -51,7 +50,6 @@
5150
],
5251
'must_query' => [
5352
'name' => 'must_query',
54-
'boost' => '1',
5553
'filterReference' => [
5654
0 => [
5755
'clause' => 'must',
@@ -62,7 +60,6 @@
6260
],
6361
'should_query' => [
6462
'name' => 'should_query',
65-
'boost' => '1',
6663
'filterReference' => [
6764
0 => [
6865
'clause' => 'should',
@@ -73,7 +70,6 @@
7370
],
7471
'not_query' => [
7572
'name' => 'not_query',
76-
'boost' => '1',
7773
'filterReference' => [
7874
0 => [
7975
'clause' => 'not',
@@ -84,7 +80,6 @@
8480
],
8581
'match_query_2' => [
8682
'value' => '$match_term_override$',
87-
'boost' => '1',
8883
'name' => 'match_query_2',
8984
'match' => [
9085
0 => [
@@ -168,7 +163,6 @@
168163
'queries' => [
169164
'filter_query' => [
170165
'name' => 'filter_query',
171-
'boost' => '1',
172166
'filterReference' => [
173167
0 =>
174168
[
@@ -236,7 +230,6 @@
236230
'new_match_query' => [
237231
'value' => '$match_term$',
238232
'name' => 'new_match_query',
239-
'boost' => '1',
240233
'match' => [
241234
0 =>
242235
[

lib/internal/Magento/Framework/Config/Dom.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ public static function validateDomDocument(
379379
libxml_set_external_entity_loader([self::$urnResolver, 'registerEntityLoader']);
380380
$errors = [];
381381
try {
382-
$result = $dom->schemaValidate($schema, LIBXML_SCHEMA_CREATE);
382+
$result = $dom->schemaValidate($schema);
383383
if (!$result) {
384384
$errors = self::getXmlErrors($errorFormat);
385385
}

lib/internal/Magento/Framework/Config/Test/Unit/DomTest.php

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -169,48 +169,6 @@ public function validateDataProvider()
169169
];
170170
}
171171

172-
/**
173-
* @param string $xml
174-
* @param string $expectedValue
175-
* @dataProvider validateWithDefaultValueDataProvider
176-
*/
177-
public function testValidateWithDefaultValue($xml, $expectedValue)
178-
{
179-
if (!function_exists('libxml_set_external_entity_loader')) {
180-
$this->markTestSkipped('Skipped on HHVM. Will be fixed in MAGETWO-45033');
181-
}
182-
183-
$actualErrors = [];
184-
185-
$dom = new \Magento\Framework\Config\Dom($xml, $this->validationStateMock);
186-
$dom->validate(__DIR__ . '/_files/sample.xsd', $actualErrors);
187-
188-
$actualValue = $dom->getDom()
189-
->getElementsByTagName('root')->item(0)
190-
->getElementsByTagName('node')->item(0)
191-
->getAttribute('attribute_with_default_value');
192-
193-
$this->assertEmpty($actualErrors);
194-
$this->assertEquals($expectedValue, $actualValue);
195-
}
196-
197-
/**
198-
* @return array
199-
*/
200-
public function validateWithDefaultValueDataProvider()
201-
{
202-
return [
203-
'default_value' => [
204-
'<root><node id="id1"/></root>',
205-
'default_value'
206-
],
207-
'custom_value' => [
208-
'<root><node id="id1" attribute_with_default_value="non_default_value"/></root>',
209-
'non_default_value'
210-
],
211-
];
212-
}
213-
214172
public function testValidateCustomErrorFormat()
215173
{
216174
$xml = '<root><unknown_node/></root>';

lib/internal/Magento/Framework/Config/Test/Unit/_files/sample.xsd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
<xs:simpleContent>
2222
<xs:extension base="xs:string">
2323
<xs:attribute name="id" type="xs:string" use="required"/>
24-
<xs:attribute name="attribute_with_default_value" type="xs:string" default="default_value"/>
2524
</xs:extension>
2625
</xs:simpleContent>
2726
</xs:complexType>

0 commit comments

Comments
 (0)