Update underscore to version 1.13.1

Author: mrtuvn

app/code/Magento/Customer/view/frontend/web/js/customer-data.js

@@ -98,8 +98,8 @@ define([
             sectionNames = sectionConfig.filterClientSideSections(sectionNames);
             parameters = _.isArray(sectionNames) && sectionNames.indexOf('*') < 0 ? {
                 sections: sectionNames.join(',')
-            } : [];
-            parameters['force_new_section_timestamp'] = forceNewSectionTimestamp;
+            } : {};
+            parameters.force_new_section_timestamp = forceNewSectionTimestamp;
 
             return $.getJSON(options.sectionLoadUrl, parameters).fail(function (jqXHR) {
                 throw new Error(jqXHR);
@@ -120,7 +120,7 @@ define([
                 storage.remove(sectionName);
                 sectionDataIds = $.cookieStorage.get('section_data_ids') || {};
                 _.each(sectionDataIds, function (data, name) {
-                    if (name != sectionName) { //eslint-disable-line eqeqeq
+                    if (name !== sectionName) {
                         newSectionDataIds[name] = data;
                     }
                 });
@@ -179,7 +179,7 @@ define([
                 sectionDataIds = $.cookieStorage.get('section_data_ids') || {};
 
             _.each(sections, function (sectionData, sectionName) {
-                sectionId = sectionData['data_id'];
+                sectionId = sectionData.data_id;
                 sectionDataIds[sectionName] = sectionId;
                 storage.set(sectionName, sectionData);
                 storageInvalidation.remove(sectionName);
@@ -255,7 +255,7 @@ define([
             _.each(options.expirableSectionNames, function (sectionName) {
                 sectionData = storage.get(sectionName);
 
-                if (typeof sectionData === 'object' && sectionData['data_id'] + sectionLifetime <= currentTimestamp) {
+                if (typeof sectionData === 'object' && sectionData.data_id + sectionLifetime <= currentTimestamp) {
                     expiredSectionNames.push(sectionName);
                 }
             });
@@ -266,7 +266,7 @@ define([
 
                 if (typeof sectionData === 'undefined' ||
                     typeof sectionData === 'object' &&
-                    cookieSectionTimestamp != sectionData['data_id'] //eslint-disable-line
+                    cookieSectionTimestamp !== sectionData.data_id
                 ) {
                     expiredSectionNames.push(sectionName);
                 }

app/code/Magento/Ui/view/base/web/js/grid/columns/image-preview.js

@@ -5,9 +5,10 @@
 /* eslint-disable no-undef */
 define([
     'jquery',
+    'underscore',
     'Magento_Ui/js/grid/columns/column',
     'Magento_Ui/js/lib/key-codes'
-], function ($, Column, keyCodes) {
+], function ($, _, Column, keyCodes) {
     'use strict';
 
     return Column.extend({

dev/tests/js/jasmine/tests/app/code/Magento/Customer/frontend/js/customer-data.test.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/* global _ */
 /* eslint max-nested-callbacks: 0 */
 /* jscs:disable jsDoc*/
 
@@ -46,6 +45,27 @@ define([
             ]
         };
 
+    var _;
+
+    beforeEach(function (done) {
+        injector.require([
+            'underscore',
+            'Magento_Customer/js/customer-data'
+        ], function (underscore, Constr) {
+            _ = underscore;
+            obj = Constr;
+            done();
+        });
+    });
+
+    afterEach(function () {
+        try {
+            injector.clean();
+            injector.remove();
+        } catch (e) {
+        }
+    });
+
     function init(config) {
         var defaultConfig = {
             sectionLoadUrl: 'http://localhost/customer/section/load/',
@@ -63,7 +83,7 @@ define([
             sectionDataIds = {};
 
         _.each(sections, function (sectionData, sectionName) {
-            sectionDataIds[sectionName] = sectionData['data_id'];
+            sectionDataIds[sectionName] = sectionData.data_id;
 
             if (typeof sectionData.content !== 'undefined') {
                 mageCacheStorage[sectionName] = sectionData;
@@ -89,34 +109,22 @@ define([
         );
     }
 
-    function clearLocalStorage() {
-        $.cookieStorage.set('section_data_ids', {});
-
-        if (window.localStorage) {
-            window.localStorage.clear();
-        }
-    }
-
     describe('Magento_Customer/js/customer-data', function () {
+        function clearLocalStorage() {
+            $.cookieStorage.set('section_data_ids', {});
 
-        var _;
+            if (window.localStorage) {
+                window.localStorage.clear();
+            }
+        }
 
         beforeAll(function () {
             clearLocalStorage();
         });
 
-        beforeEach(function (done) {
+        beforeEach(function () {
             originalGetJSON = $.getJSON;
             sectionConfig['Magento_Customer/js/section-config'](sectionConfigSettings);
-
-            injector.require([
-                'underscore',
-                'Magento_Customer/js/customer-data'
-            ], function (underscore, Constr) {
-                _ = underscore;
-                obj = Constr;
-                done();
-            });
         });
 
         afterEach(function () {
@@ -401,16 +409,13 @@ define([
                             }
                         };
                     };
-
                     expect(parameters).toEqual(jasmine.objectContaining({
                         sections: 'section'
                     }));
-
                     return deferred.promise();
                 });
 
                 result = obj.reload(['section'], true);
-
                 expect(result).toEqual(jasmine.objectContaining({
                     responseJSON: {
                         section: {}
@@ -422,7 +427,6 @@ define([
                 var result;
 
                 spyOn(sectionConfig, 'filterClientSideSections').and.returnValue(['cart,customer,messages']);
-
                 $.getJSON = jasmine.createSpy().and.callFake(function (url, parameters) {
                     var deferred = $.Deferred();
 
@@ -448,7 +452,6 @@ define([
                 });
 
                 result = obj.reload(['cart', 'customer', 'messages'], true);
-
                 expect(result).toEqual(jasmine.objectContaining({
                     responseJSON: {
                         cart: {},
@@ -457,7 +460,7 @@ define([
                     }
                 }));
             });
-            //
+
             it('Check it returns all sections when passed wildcard string', function () {
                 var result;
 
@@ -486,7 +489,6 @@ define([
                 });
 
                 result = obj.reload('*', true);
-
                 expect($.getJSON).toHaveBeenCalled();
                 expect(result).toEqual(jasmine.objectContaining({
                     responseJSON: {