Skip to content

Commit 88090b7

Browse files
Merge remote-tracking branch '36975/feature/php8.1-constructor-property-promotion-wee-graph-ql' into commprs_feb
2 parents f645b64 + ef33008 commit 88090b7

File tree

4 files changed

+17
-43
lines changed

4 files changed

+17
-43
lines changed

app/code/Magento/WeeeGraphQl/Model/Resolver/FixedProductTax.php

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,14 @@
2121
*/
2222
class FixedProductTax implements ResolverInterface
2323
{
24-
/**
25-
* @var Data
26-
*/
27-
private $weeeHelper;
28-
29-
/**
30-
* @var TaxHelper
31-
*/
32-
private $taxHelper;
33-
3424
/**
3525
* @param Data $weeeHelper
3626
* @param TaxHelper $taxHelper
3727
*/
38-
public function __construct(Data $weeeHelper, TaxHelper $taxHelper)
39-
{
40-
$this->weeeHelper = $weeeHelper;
41-
$this->taxHelper = $taxHelper;
28+
public function __construct(
29+
private readonly Data $weeeHelper,
30+
private readonly TaxHelper $taxHelper
31+
) {
4232
}
4333

4434
/**

app/code/Magento/WeeeGraphQl/Model/Resolver/Quote/FixedProductTax.php

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,14 @@
2121
*/
2222
class FixedProductTax implements ResolverInterface
2323
{
24-
/**
25-
* @var Data
26-
*/
27-
private $weeeHelper;
28-
29-
/**
30-
* @var TaxHelper
31-
*/
32-
private $taxHelper;
33-
3424
/**
3525
* @param Data $weeeHelper
3626
* @param TaxHelper $taxHelper
3727
*/
38-
public function __construct(Data $weeeHelper, TaxHelper $taxHelper)
39-
{
40-
$this->weeeHelper = $weeeHelper;
41-
$this->taxHelper = $taxHelper;
28+
public function __construct(
29+
private readonly Data $weeeHelper,
30+
private readonly TaxHelper $taxHelper
31+
) {
4232
}
4333

4434
/**

app/code/Magento/WeeeGraphQl/Model/Resolver/StoreConfig.php

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,6 @@ class StoreConfig implements ResolverInterface, ResetAfterRequestInterface
3737
WeeeDisplayConfig::DISPLAY_EXCL => 'EXCLUDE_FPT_WITHOUT_DETAILS'
3838
];
3939

40-
/**
41-
* @var Data
42-
*/
43-
private $weeeHelper;
44-
45-
/**
46-
* @var TaxHelper
47-
*/
48-
private $taxHelper;
49-
5040
/**
5141
* @var array
5242
*/
@@ -56,10 +46,10 @@ class StoreConfig implements ResolverInterface, ResetAfterRequestInterface
5646
* @param Data $weeeHelper
5747
* @param TaxHelper $taxHelper
5848
*/
59-
public function __construct(Data $weeeHelper, TaxHelper $taxHelper)
60-
{
61-
$this->weeeHelper = $weeeHelper;
62-
$this->taxHelper = $taxHelper;
49+
public function __construct(
50+
private readonly Data $weeeHelper,
51+
private readonly TaxHelper $taxHelper
52+
) {
6353
}
6454

6555
/**

app/code/Magento/WeeeGraphQl/registration.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,8 @@
66

77
use Magento\Framework\Component\ComponentRegistrar;
88

9-
ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_WeeeGraphQl', __DIR__);
9+
ComponentRegistrar::register(
10+
ComponentRegistrar::MODULE,
11+
'Magento_WeeeGraphQl',
12+
__DIR__
13+
);

0 commit comments

Comments
 (0)