MC-19607: Mass delete deletes all products

Oleksandr Iegorov · Oleksandr Iegorov · commit 87dff07de468 · 2019-10-17T15:37:45.000-05:00
diff --git a/app/code/Magento/CatalogSearch/Ui/DataProvider/Product/AddFulltextFilterToCollection.php b/app/code/Magento/CatalogSearch/Ui/DataProvider/Product/AddFulltextFilterToCollection.php
@@ -40,6 +40,10 @@ public function addFilter(Collection $collection, $field, $condition = null)
         if (isset($condition['fulltext']) && (string)$condition['fulltext'] !== '') {
             $this->searchCollection->addBackendSearchFilter($condition['fulltext']);
             $productIds = $this->searchCollection->load()->getAllIds();
+            if (empty($productIds)) {
+                //add dummy id to prevent returning full unfiltered collection
+                $productIds = -1;
+            }
             $collection->addIdFilter($productIds);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,10 @@ public function addFilter(Collection $collection, $field, $condition = null)`
`40`	`40`	`if (isset($condition['fulltext']) && (string)$condition['fulltext'] !== '') {`
`41`	`41`	`$this->searchCollection->addBackendSearchFilter($condition['fulltext']);`
`42`	`42`	`$productIds = $this->searchCollection->load()->getAllIds();`
	`43`	`+ if (empty($productIds)) {`
	`44`	`+ //add dummy id to prevent returning full unfiltered collection`
	`45`	`+ $productIds = -1;`
	`46`	`+ }`
`43`	`47`	`$collection->addIdFilter($productIds);`
`44`	`48`	`}`
`45`	`49`	`}`