Skip to content

Commit 876aafd

Browse files
committed
Merge remote-tracking branch 'goinc/MAGETWO-50794' into pr-515
2 parents 8221fc9 + f0a87b5 commit 876aafd

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

app/code/Magento/CatalogWidget/Model/Rule/Condition/Combine.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,9 @@ public function getNewChildSelectOptions()
7171
*/
7272
public function collectValidatedAttributes($productCollection)
7373
{
74+
$alias = array_keys($productCollection->getSelect()->getPart('from'))[0];
7475
foreach ($this->getConditions() as $condition) {
76+
$condition->setData('attribute', $alias . '.' . $condition->getData('attribute'));
7577
$condition->addToCollection($productCollection);
7678
}
7779
return $this;

app/code/Magento/CatalogWidget/Test/Unit/Model/Rule/Condition/CombineTest.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,13 @@ public function testGetNewChildSelectOptions()
7373
public function testCollectValidatedAttributes()
7474
{
7575
$collection = $this->getMockBuilder('\Magento\Catalog\Model\ResourceModel\Product\Collection')
76-
->disableOriginalConstructor()
76+
->disableOriginalConstructor()->setMethods(['getSelect'])
77+
->getMock();
78+
$select = $this->getMockBuilder('\Magento\Framework\DB\Select')
79+
->disableOriginalConstructor()->setMethods(['getPart'])
7780
->getMock();
81+
$select->expects($this->any())->method('getPart')->with('from')->willReturn(['alias_table' => 'table_name']);
82+
$collection->expects($this->any())->method('getSelect')->willReturn($select);
7883
$condition = $this->getMockBuilder('Magento\CatalogWidget\Model\Rule\Condition\Combine')
7984
->disableOriginalConstructor()->setMethods(['addToCollection'])
8085
->getMock();

0 commit comments

Comments
 (0)