Skip to content

Commit 874da11

Browse files
committed
DOC-475: Enter review comments
1 parent 78d8ae6 commit 874da11

File tree

6 files changed

+17
-17
lines changed

6 files changed

+17
-17
lines changed

app/code/Magento/CheckoutAgreementsGraphQl/etc/schema.graphqls

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ type Query {
55
checkoutAgreements: [CheckoutAgreement] @resolver(class: "Magento\\CheckoutAgreementsGraphQl\\Model\\Resolver\\CheckoutAgreements") @doc(description: "Return Terms and Conditions configuration information.")
66
}
77

8-
type CheckoutAgreement @doc(description: "Contains details about an individual checkout agreement.") {
9-
agreement_id: Int! @doc(description: "The identifier for a checkout agreement.")
8+
type CheckoutAgreement @doc(description: "Defines details about an individual checkout agreement.") {
9+
agreement_id: Int! @doc(description: "The ID for a checkout agreement.")
1010
name: String! @doc(description: "The name given to the condition.")
11-
content: String! @doc(description: "The text of the agreement.")
11+
content: String! @doc(description: "Required. The text of the agreement.")
1212
content_height: String @doc(description: "The height of the text box where the Terms and Conditions statement appears during checkout.")
1313
checkbox_text: String! @doc(description: "The checkbox text for the checkout agreement.")
1414
is_html: Boolean! @doc(description: "Indicates whether the `content` text is in HTML format.")
@@ -17,5 +17,5 @@ type CheckoutAgreement @doc(description: "Contains details about an individual c
1717

1818
enum CheckoutAgreementMode @doc(description: "Indicates how agreements are accepted.") {
1919
AUTO @doc(description: "Conditions are automatically accepted upon checkout.")
20-
MANUAL @doc(description: "Shoppers are required to manually accept the conditions to place an order.")
20+
MANUAL @doc(description: "Shoppers must manually accept the conditions to place an order.")
2121
}

app/code/Magento/EavGraphQl/etc/schema.graphqls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ type AttributeOption @doc(description: "Defines an attribute option.") {
3737
value: String @doc(description: "The attribute option value.")
3838
}
3939

40-
input AttributeInput @doc(description: "Specifies the `attribute_code` and `entity_type` to search.") {
40+
input AttributeInput @doc(description: "Defines the attribute characteristics to search for the `attribute_code` and `entity_type` to search.") {
4141
attribute_code: String @doc(description: "The unique identifier for an attribute code. This value should be in lowercase letters without spaces.")
4242
entity_type: String @doc(description: "The type of entity that defines the attribute.")
4343
}

app/code/Magento/GraphQl/etc/schema.graphqls

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ type Mutation {
5050
input FilterTypeInput @doc(description: "Defines the comparison operators that can be used in a filter.") {
5151
eq: String @doc(description: "Equals.")
5252
finset: [String] @deprecated (reason: "We do not recommend storing comma separated values, therefore the `finset` filter is redundant.")
53-
from: String @doc(description: "From. Must be used with `to`.")
53+
from: String @doc(description: "From. Must be used with the `to` field.")
5454
gt: String @doc(description: "Greater than.")
5555
gteq: String @doc(description: "Greater than or equal to.")
5656
in: [String] @doc(description: "In. The value can contain a set of comma-separated values.")
@@ -61,7 +61,7 @@ input FilterTypeInput @doc(description: "Defines the comparison operators that c
6161
neq: String @doc(description: "Not equal to.")
6262
notnull: String @doc(description: "Not null.")
6363
null: String @doc(description: "Is null.")
64-
to: String@doc(description: "To. Must be used with `from`.")
64+
to: String@doc(description: "To. Must be used with the `from` field.")
6565
nin: [String] @doc(description: "Not in. The value can contain a set of comma-separated values.")
6666
}
6767

@@ -97,7 +97,7 @@ enum SortEnum @doc(description: "Indicates whether to return results in ascendin
9797
}
9898

9999
type ComplexTextValue {
100-
html: String! @doc(description: "Text that can contain HTML formatting.")
100+
html: String! @doc(description: "Text that can contain HTML tags.")
101101
}
102102

103103
type Money @doc(description: "Defines a monetary value, including a numeric value and a currency code.") {

app/code/Magento/NewsletterGraphQl/etc/schema.graphqls

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
# See COPYING.txt for license details.
33

44
type Mutation {
5-
subscribeEmailToNewsletter(email: String! @doc(description: "The email address to subscribe.")): SubscribeEmailToNewsletterOutput @doc(description:"Subscribe the specified email to the store's newsletter.") @resolver(class: "Magento\\NewsletterGraphQl\\Model\\Resolver\\SubscribeEmailToNewsletter")
5+
subscribeEmailToNewsletter(email: String! @doc(description: "The email address that will receive the store's newsletter.")): SubscribeEmailToNewsletterOutput @doc(description:"Subscribe the specified email to the store's newsletter.") @resolver(class: "Magento\\NewsletterGraphQl\\Model\\Resolver\\SubscribeEmailToNewsletter")
66
}
77

8-
type SubscribeEmailToNewsletterOutput @doc(description: "Contains the status of the request.") {
8+
type SubscribeEmailToNewsletterOutput @doc(description: "Contains the result of the `subscribeEmailToNewsletter` operation.") {
99
status: SubscriptionStatusesEnum @doc(description: "The status of the subscription request.")
1010
}
1111

app/code/Magento/SwatchesGraphQl/etc/schema.graphqls

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ input ProductFilterInput {
1010
}
1111

1212
input ProductSortInput {
13-
swatch_image: SortEnum @doc(description: "Indicates how to sort the swatches.")
13+
swatch_image: SortEnum @doc(description: "Indicates the criteria to sort swatches.")
1414
}
1515

1616
interface SwatchLayerFilterItemInterface @typeResolver(class: "Magento\\SwatchesGraphQl\\Model\\Resolver\\SwatchLayerFilterItemResolver")
@@ -33,11 +33,11 @@ type ConfigurableProductOptionsValues {
3333
}
3434

3535
interface SwatchDataInterface @typeResolver(class: "Magento\\SwatchesGraphQl\\Model\\Resolver\\Product\\Options\\SwatchDataTypeResolver") {
36-
value: String @doc(description: "The value of a swatch item. It could be a HEX color code, image link, or text value.")
36+
value: String @doc(description: "The value can be represented as color (HEX code), image link, or text.")
3737
}
3838

3939
type ImageSwatchData implements SwatchDataInterface {
40-
thumbnail: String @doc(description: "The URL to the thumbnail swatch image.")
40+
thumbnail: String @doc(description: "The URL assigned to the thumbnail of the swatch image.")
4141
}
4242

4343
type TextSwatchData implements SwatchDataInterface {
@@ -49,5 +49,5 @@ type ColorSwatchData implements SwatchDataInterface {
4949
}
5050

5151
type ConfigurableProductOptionValue {
52-
swatch: SwatchDataInterface @resolver(class: "Magento\\SwatchesGraphQl\\Model\\Resolver\\Product\\Options\\SwatchData") @doc(description: "The URL to the thumbnail swatch image.")
52+
swatch: SwatchDataInterface @resolver(class: "Magento\\SwatchesGraphQl\\Model\\Resolver\\Product\\Options\\SwatchData") @doc(description: "The URL assigned to the thumbnail of the swatch image.")
5353
}

app/code/Magento/VaultGraphQl/etc/schema.graphqls

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,19 @@
22
# See COPYING.txt for license details.
33

44
type Mutation {
5-
deletePaymentToken(public_hash: String! @doc(description: "The public token that is stored in the vault.")): DeletePaymentTokenOutput @resolver(class: "\\Magento\\VaultGraphQl\\Model\\Resolver\\DeletePaymentToken") @doc(description:"Delete a customer's payment token.")
5+
deletePaymentToken(public_hash: String! @doc(description: "The reusable payment token securely stored in the vault.")): DeletePaymentTokenOutput @resolver(class: "\\Magento\\VaultGraphQl\\Model\\Resolver\\DeletePaymentToken") @doc(description:"Delete a customer's payment token.")
66
}
77

88
type DeletePaymentTokenOutput @doc(description: "Indicates whether the request succeeded and returns the remaining customer payment tokens.") {
99
result: Boolean! @doc(description: "Indicates whether the request succeeded.")
10-
customerPaymentTokens: CustomerPaymentTokens @resolver(class: "\\Magento\\VaultGraphQl\\Model\\Resolver\\PaymentTokens") @doc(description: "An array of the customer's remaining payment tokens.")
10+
customerPaymentTokens: CustomerPaymentTokens @resolver(class: "\\Magento\\VaultGraphQl\\Model\\Resolver\\PaymentTokens") @doc(description: "A container for the customer's remaining payment tokens.")
1111
}
1212

1313
type Query {
1414
customerPaymentTokens: CustomerPaymentTokens @doc(description: "Return a list of customer payment tokens stored in the vault.") @resolver(class: "\\Magento\\VaultGraphQl\\Model\\Resolver\\PaymentTokens") @cache(cacheable: false)
1515
}
1616

17-
type CustomerPaymentTokens @resolver(class: "\\Magento\\VaultGraphQl\\Model\\Resolver\\PaymentTokens") @doc(description: "Contains an array of the payment token stored in the customer's vault.") {
17+
type CustomerPaymentTokens @resolver(class: "\\Magento\\VaultGraphQl\\Model\\Resolver\\PaymentTokens") @doc(description: "Contains payment tokens stored in the customer's vault.") {
1818
items: [PaymentToken]! @doc(description: "An array of payment tokens.")
1919
}
2020

0 commit comments

Comments
 (0)