Skip to content

Commit 867fb93

Browse files
author
Prabhu Ram
committed
MC-19254: Implement the schema changes
- Added validation for 0 discount amount
1 parent 72999cb commit 867fb93

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

app/code/Magento/SalesRule/Model/RulesApplier.php

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -203,16 +203,18 @@ protected function getDiscountData($item, $rule)
203203
*/
204204
private function setDiscountBreakdown($discountData, $item, $rule)
205205
{
206-
/** @var \Magento\SalesRule\Model\Rule\Action\Discount\Data $discount */
207-
$discount = $this->discountFactory->create();
208-
$discount->setBaseOriginalAmount($discountData->getBaseOriginalAmount());
209-
$discount->setAmount($discountData->getAmount());
210-
$discount->setBaseAmount($discountData->getBaseAmount());
211-
$discount->setOriginalAmount($discountData->getOriginalAmount());
212-
$discountBreakdown = $item->getExtensionAttributes()->getDiscounts() ?? [];
213-
$discountBreakdown[$rule->getId()]['discount'] = $discount;
214-
$discountBreakdown[$rule->getId()]['rule'] = $rule;
215-
$item->getExtensionAttributes()->setDiscounts($discountBreakdown);
206+
if ($discountData->getAmount() > 0) {
207+
/** @var \Magento\SalesRule\Model\Rule\Action\Discount\Data $discount */
208+
$discount = $this->discountFactory->create();
209+
$discount->setBaseOriginalAmount($discountData->getBaseOriginalAmount());
210+
$discount->setAmount($discountData->getAmount());
211+
$discount->setBaseAmount($discountData->getBaseAmount());
212+
$discount->setOriginalAmount($discountData->getOriginalAmount());
213+
$discountBreakdown = $item->getExtensionAttributes()->getDiscounts() ?? [];
214+
$discountBreakdown[$rule->getId()]['discount'] = $discount;
215+
$discountBreakdown[$rule->getId()]['rule'] = $rule;
216+
$item->getExtensionAttributes()->setDiscounts($discountBreakdown);
217+
}
216218
return $this;
217219
}
218220

0 commit comments

Comments
 (0)