MC-18193: All Sales emails are being copied to the same customer when sales_emails cron has an error

Author: rostyslav-hymon

lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php

@@ -264,11 +264,9 @@ public function getTransport()
         try {
             $this->prepareMessage();
             $mailTransport = $this->mailTransportFactory->create(['message' => clone $this->message]);
-        } catch (LocalizedException $e) {
+        } finally {
             $this->reset();
-            throw $e;
         }
-        $this->reset();
 
         return $mailTransport;
     }

lib/internal/Magento/Framework/Mail/Test/Unit/Template/TransportBuilderTest.php

@@ -143,6 +143,34 @@ public function testGetTransport($templateType, $messageType, $bodyText, $templa
         $this->assertInstanceOf(\Magento\Framework\Mail\TransportInterface::class, $this->builder->getTransport());
     }
 
+    /**
+     * Test get transport with exception
+     *
+     * @expectedException \Magento\Framework\Exception\LocalizedException
+     * @expectedExceptionMessage Unknown template type
+     */
+    public function testGetTransportWithException()
+    {
+        $this->builder->setTemplateModel('Test\Namespace\Template');
+
+        $vars = ['reason' => 'Reason', 'customer' => 'Customer'];
+        $options = ['area' => 'frontend', 'store' => 1];
+
+        $template = $this->createMock(\Magento\Framework\Mail\TemplateInterface::class);
+        $template->expects($this->once())->method('setVars')->with($this->equalTo($vars))->willReturnSelf();
+        $template->expects($this->once())->method('setOptions')->with($this->equalTo($options))->willReturnSelf();
+        $template->expects($this->once())->method('getType')->willReturn('Unknown');
+        $this->messageFactoryMock->expects($this->once())->method('create');
+        $this->templateFactoryMock->expects($this->once())
+            ->method('get')
+            ->with($this->equalTo('identifier'), $this->equalTo('Test\Namespace\Template'))
+            ->willReturn($template);
+
+        $this->builder->setTemplateIdentifier('identifier')->setTemplateVars($vars)->setTemplateOptions($options);
+
+        $this->assertInstanceOf(\Magento\Framework\Mail\TransportInterface::class, $this->builder->getTransport());
+    }
+
     /**
      * @return array
      */