Skip to content

Commit 860b8a3

Browse files
AnujNehraAnujNehra
authored andcommitted
ACP2E-2247: [Cloud] Misleading prompts on Additional Settings section when setting up a Tax Rule:
1 parent 22b8802 commit 860b8a3

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

app/code/Magento/Tax/Test/Mftf/Test/AdminCheckTaxForDetailsTagExpandCollapseTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<!-- Click expand icon -->
3333
<conditionalClick selector="{{AdminTaxRuleFormSection.additionalSettings}}" dependentSelector="{{AdminTaxRuleFormSection.additionalSettingsOpened}}" visible="false" stepKey="openAdditionalSettings"/>
3434
<!-- Check class in selector -->
35-
<seeElement selector="details#detailsbase_fieldset .__show" stepKey="seeBox"/>
35+
<seeElement selector="details#detailsbase_fieldset ._show" stepKey="seeBox"/>
3636
<!--Logout-->
3737
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutFromAdmin"/>
3838
</after>

app/code/Magento/Tax/view/adminhtml/templates/rule/edit.phtml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -322,11 +322,11 @@ $scriptString.= <<<script
322322
require(['jquery'], function($) {
323323
jQuery('.admin__collapsible-block-wrapper').on('click', function () {
324324
if(!this.hasAttribute('open')) {
325-
jQuery(this).addClass('__show');
326-
jQuery(this).children().addClass('__show');
325+
jQuery(this).addClass('_show');
326+
jQuery(this).children().addClass('_show');
327327
} else {
328-
jQuery(this).removeClass('__show');
329-
jQuery(this).children().removeClass('__show');
328+
jQuery(this).removeClass('_show');
329+
jQuery(this).children().removeClass('_show');
330330
}
331331
});
332332
});

app/design/adminhtml/Magento/backend/Magento_Tax/web/css/source/_module.less

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,15 @@
2929
}
3030
}
3131

32-
.admin__collapsible-block-wrapper.__show .admin__collapsible-title.__show:before {
33-
content: @icon-expand-close__content;
34-
font-size: @collapsible-title-icon__size;
35-
position: absolute;
36-
right: @data-grid__font-size;
37-
top: 2.3rem;
32+
.admin__collapsible-block-wrapper {
33+
.admin__collapsible-title._show {
34+
&:before {
35+
content: @icon-expand-close__content;
36+
font-size: @collapsible-title-icon__size;
37+
position: absolute;
38+
right: @data-grid__font-size;
39+
top: 2.3rem;
40+
}
41+
}
3842
}
3943
//@codingStandardsIgnoreEnd

0 commit comments

Comments
 (0)