Skip to content

Commit 85a68e5

Browse files
committed
#AC-8918::XML to REST API-Code review changes- fixes on static tests failures
1 parent e4b4165 commit 85a68e5

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

app/code/Magento/Ups/Model/Carrier.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1752,10 +1752,6 @@ private function createPackages(float $totalWeight, array $packages): array
17521752
*/
17531753
protected function _doShipmentRequest(\Magento\Framework\DataObject $request)
17541754
{
1755-
/*
1756-
* This method intentionally has no implementation.
1757-
* TODO: Implement the logic here when needed in the future.
1758-
*/
1759-
//phpcs:enable
1755+
return ''; //This method has kept empty as not required.
17601756
}
17611757
}

app/code/Magento/Ups/Model/UpsAuth.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,6 @@ public function getAccessToken($clientId, $clientSecret, $clientUrl)
130130
*/
131131
public function collectRates(RateRequest $request)
132132
{
133-
/*
134-
* This method intentionally has no implementation.
135-
* TODO: Implement the logic here when needed in the future.
136-
*/
133+
return ''; // This method has kept empty as not required.
137134
}
138-
// phpcs:enable
139135
}

0 commit comments

Comments
 (0)