Skip to content

Commit 85a0235

Browse files
committed
Refactoring. Use action groups and config data
1 parent 35c155d commit 85a0235

File tree

3 files changed

+11
-17
lines changed

3 files changed

+11
-17
lines changed

app/code/Magento/Customer/Test/Mftf/ActionGroup/SignUpNewUserFromStorefrontActionGroup.xml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,4 @@
154154
<waitForPageLoad stepKey="waitForRegistered" after="clickCreateAccountButton"/>
155155
<remove keyForRemoval="seeThankYouMessage"/>
156156
</actionGroup>
157-
158-
<actionGroup name="SignUpNewCustomerNoAssertions" extends="SignUpNewUserFromStorefrontActionGroup">
159-
<remove keyForRemoval="seeThankYouMessage"/>
160-
<remove keyForRemoval="seeFirstName"/>
161-
<remove keyForRemoval="seeLastName"/>
162-
<remove keyForRemoval="seeEmail"/>
163-
</actionGroup>
164-
</actionGroups>
157+
</actionGroups>

app/code/Magento/Customer/Test/Mftf/Data/CustomerData.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@
3333
<data key="disable_auto_group_change">0</data>
3434
<!--requiredEntity type="extension_attribute">ExtensionAttributeSimple</requiredEntity-->
3535
</entity>
36-
<entity name="CustomerEntityOneNotUniqueEmail" extends="CustomerEntityOne" type="customer">
37-
<data key="email">test@email.com</data>
38-
</entity>
3936
<entity name="Simple_US_Customer" type="customer">
4037
<data key="group_id">1</data>
4138
<data key="default_billing">true</data>

app/code/Magento/Customer/Test/Mftf/Test/StorefrontCreateExistingCustomerTest.xml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,20 @@
1717
<group value="mtf_migrated"/>
1818
</annotations>
1919
<before>
20-
<createData stepKey="customer" entity="CustomerEntityOneNotUniqueEmail"/>
20+
<createData entity="Simple_US_Customer" stepKey="customer"/>
2121
</before>
2222
<after>
23-
<deleteData stepKey="deleteCustomer" createDataKey="customer" />
23+
<deleteData createDataKey="customer" stepKey="deleteCustomer"/>
2424
</after>
2525

26-
<actionGroup ref="SignUpNewCustomerNoAssertions" stepKey="SignUpNewUser">
27-
<argument name="Customer" value="CustomerEntityOneNotUniqueEmail"/>
26+
<actionGroup ref="StorefrontOpenCustomerAccountCreatePageActionGroup" stepKey="openCreateAccountPage"/>
27+
<actionGroup ref="StorefrontFillCustomerAccountCreationFormActionGroup" stepKey="fillCreateAccountForm">
28+
<argument name="customer" value="$$customer$$"/>
29+
</actionGroup>
30+
<actionGroup ref="StorefrontClickCreateAnAccountCustomerAccountCreationFormActionGroup" stepKey="submitCreateAccountForm"/>
31+
<actionGroup ref="AssertMessageCustomerCreateAccountActionGroup" stepKey="seeErrorMessage">
32+
<argument name="messageType" value="error"/>
33+
<argument name="message" value="There is already an account with this email address."/>
2834
</actionGroup>
29-
<waitForElementVisible selector="{{StorefrontCustomerMessagesSection.errorMessage}}" stepKey="waitForErrorMessage" />
30-
<see stepKey="seeErrorMessage" userInput="There is already an account with this email address." selector="{{StorefrontCustomerMessagesSection.errorMessage}}"/>
3135
</test>
3236
</tests>

0 commit comments

Comments
 (0)