Skip to content

Commit 84c1213

Browse files
author
Magento CICD
authored
merge magento/2.3-develop into magento-obsessive-owls/cms-team-1-delivery-sprint-4
2 parents 1419335 + cc617b0 commit 84c1213

File tree

331 files changed

+7249
-2406
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

331 files changed

+7249
-2406
lines changed

‎.travis.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ services:
1616
- elasticsearch
1717
language: php
1818
php:
19-
- 7.0
2019
- 7.1
2120
env:
2221
global:
@@ -33,16 +32,6 @@ env:
3332
- TEST_SUITE=integration INTEGRATION_INDEX=2
3433
- TEST_SUITE=integration INTEGRATION_INDEX=3
3534
- TEST_SUITE=functional
36-
matrix:
37-
exclude:
38-
- php: 7.0
39-
env: TEST_SUITE=static
40-
- php: 7.0
41-
env: TEST_SUITE=js GRUNT_COMMAND=spec
42-
- php: 7.0
43-
env: TEST_SUITE=js GRUNT_COMMAND=static
44-
- php: 7.0
45-
env: TEST_SUITE=functional
4635
cache:
4736
apt: true
4837
directories:

‎app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MarkAsRead.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ public function execute()
2828
)->markAsRead(
2929
$notificationId
3030
);
31-
$this->messageManager->addSuccess(__('The message has been marked as Read.'));
31+
$this->messageManager->addSuccessMessage(__('The message has been marked as Read.'));
3232
} catch (\Magento\Framework\Exception\LocalizedException $e) {
33-
$this->messageManager->addError($e->getMessage());
33+
$this->messageManager->addErrorMessage($e->getMessage());
3434
} catch (\Exception $e) {
35-
$this->messageManager->addException(
35+
$this->messageManager->addExceptionMessage(
3636
$e,
3737
__("We couldn't mark the notification as Read because of an error.")
3838
);

‎app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassMarkAsRead.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public function execute()
2323
{
2424
$ids = $this->getRequest()->getParam('notification');
2525
if (!is_array($ids)) {
26-
$this->messageManager->addError(__('Please select messages.'));
26+
$this->messageManager->addErrorMessage(__('Please select messages.'));
2727
} else {
2828
try {
2929
foreach ($ids as $id) {
@@ -32,13 +32,13 @@ public function execute()
3232
$model->setIsRead(1)->save();
3333
}
3434
}
35-
$this->messageManager->addSuccess(
35+
$this->messageManager->addSuccessMessage(
3636
__('A total of %1 record(s) have been marked as Read.', count($ids))
3737
);
3838
} catch (\Magento\Framework\Exception\LocalizedException $e) {
39-
$this->messageManager->addError($e->getMessage());
39+
$this->messageManager->addErrorMessage($e->getMessage());
4040
} catch (\Exception $e) {
41-
$this->messageManager->addException(
41+
$this->messageManager->addExceptionMessage(
4242
$e,
4343
__("We couldn't mark the notification as Read because of an error.")
4444
);

‎app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassRemove.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public function execute()
2323
{
2424
$ids = $this->getRequest()->getParam('notification');
2525
if (!is_array($ids)) {
26-
$this->messageManager->addError(__('Please select messages.'));
26+
$this->messageManager->addErrorMessage(__('Please select messages.'));
2727
} else {
2828
try {
2929
foreach ($ids as $id) {
@@ -32,11 +32,14 @@ public function execute()
3232
$model->setIsRemove(1)->save();
3333
}
3434
}
35-
$this->messageManager->addSuccess(__('Total of %1 record(s) have been removed.', count($ids)));
35+
$this->messageManager->addSuccessMessage(__('Total of %1 record(s) have been removed.', count($ids)));
3636
} catch (\Magento\Framework\Exception\LocalizedException $e) {
37-
$this->messageManager->addError($e->getMessage());
37+
$this->messageManager->addErrorMessage($e->getMessage());
3838
} catch (\Exception $e) {
39-
$this->messageManager->addException($e, __("We couldn't remove the messages because of an error."));
39+
$this->messageManager->addExceptionMessage(
40+
$e,
41+
__("We couldn't remove the messages because of an error.")
42+
);
4043
}
4144
}
4245
$this->_redirect('adminhtml/*/');

‎app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/Remove.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,14 @@ public function execute()
3131

3232
try {
3333
$model->setIsRemove(1)->save();
34-
$this->messageManager->addSuccess(__('The message has been removed.'));
34+
$this->messageManager->addSuccessMessage(__('The message has been removed.'));
3535
} catch (\Magento\Framework\Exception\LocalizedException $e) {
36-
$this->messageManager->addError($e->getMessage());
36+
$this->messageManager->addErrorMessage($e->getMessage());
3737
} catch (\Exception $e) {
38-
$this->messageManager->addException($e, __("We couldn't remove the messages because of an error."));
38+
$this->messageManager->addExceptionMessage(
39+
$e,
40+
__("We couldn't remove the messages because of an error.")
41+
);
3942
}
4043

4144
$this->_redirect('adminhtml/*/');

‎app/code/Magento/Backend/Ui/Component/Control/DeleteButton.php

Lines changed: 104 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,104 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\Backend\Ui\Component\Control;
9+
10+
use Magento\Framework\App\RequestInterface;
11+
use Magento\Framework\Escaper;
12+
use Magento\Framework\UrlInterface;
13+
use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
14+
15+
/**
16+
* Represents delete button with pre-configured options
17+
* Provide an ability to show confirmation message on click on the "Delete" button
18+
*
19+
* @api
20+
*/
21+
class DeleteButton implements ButtonProviderInterface
22+
{
23+
/**
24+
* @var RequestInterface
25+
*/
26+
private $request;
27+
28+
/**
29+
* @var UrlInterface
30+
*/
31+
private $urlBuilder;
32+
33+
/**
34+
* @var Escaper
35+
*/
36+
private $escaper;
37+
38+
/**
39+
* @var string
40+
*/
41+
private $confirmationMessage;
42+
43+
/**
44+
* @var string
45+
*/
46+
private $idFieldName;
47+
48+
/**
49+
* @var string
50+
*/
51+
private $deleteRoutePath;
52+
53+
/**
54+
* @var int
55+
*/
56+
private $sortOrder;
57+
58+
/**
59+
* @param RequestInterface $request
60+
* @param UrlInterface $urlBuilder
61+
* @param Escaper $escaper
62+
* @param string $confirmationMessage
63+
* @param string $idFieldName
64+
* @param string $deleteRoutePath
65+
* @param int $sortOrder
66+
*/
67+
public function __construct(
68+
RequestInterface $request,
69+
UrlInterface $urlBuilder,
70+
Escaper $escaper,
71+
string $confirmationMessage,
72+
string $idFieldName,
73+
string $deleteRoutePath,
74+
int $sortOrder
75+
) {
76+
$this->request = $request;
77+
$this->urlBuilder = $urlBuilder;
78+
$this->escaper = $escaper;
79+
$this->confirmationMessage = $confirmationMessage;
80+
$this->idFieldName = $idFieldName;
81+
$this->deleteRoutePath = $deleteRoutePath;
82+
$this->sortOrder = $sortOrder;
83+
}
84+
85+
/**
86+
* {@inheritdoc}
87+
*/
88+
public function getButtonData()
89+
{
90+
$data = [];
91+
$fieldId = $this->escaper->escapeJs($this->escaper->escapeHtml($this->request->getParam($this->idFieldName)));
92+
if (null !== $fieldId) {
93+
$url = $this->urlBuilder->getUrl($this->deleteRoutePath);
94+
$escapedMessage = $this->escaper->escapeJs($this->escaper->escapeHtml($this->confirmationMessage));
95+
$data = [
96+
'label' => __('Delete'),
97+
'class' => 'delete',
98+
'on_click' => "deleteConfirm('{$escapedMessage}', '{$url}', {data:{{$this->idFieldName}:{$fieldId}}})",
99+
'sort_order' => $this->sortOrder,
100+
];
101+
}
102+
return $data;
103+
}
104+
}

‎app/code/Magento/Backend/view/adminhtml/web/template/dynamic-rows/grid.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*/
66
-->
77

8-
<div class="admin__field-complex" if="element.addButton">
8+
<div class="admin__field-complex" if="$data.addButton">
99
<div class="admin__field-complex-title">
1010
<span class="label" translate="'User Agent Rules'"></span>
1111
</div>
@@ -27,10 +27,10 @@
2727
<div class="admin__field admin__field-wide"
2828
visible="visible"
2929
disabled="disabled"
30-
css="element.setClasses(element)"
30+
css="$data.setClasses($data)"
3131
attr="'data-index': index">
32-
<label if="element.label" class="admin__field-label" attr="for: element.uid">
33-
<span translate="element.label"/>
32+
<label if="$data.label" class="admin__field-label" attr="for: $data.uid">
33+
<span translate="$data.label"/>
3434
</label>
3535

3636
<div class="admin__field-control" data-role="grid-wrapper">

‎app/code/Magento/Braintree/Block/Form.php

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
use Magento\Braintree\Gateway\Config\Config as GatewayConfig;
1010
use Magento\Braintree\Model\Adminhtml\Source\CcType;
1111
use Magento\Braintree\Model\Ui\ConfigProvider;
12-
use Magento\Framework\App\ObjectManager;
1312
use Magento\Framework\View\Element\Template\Context;
1413
use Magento\Payment\Block\Form\Cc;
1514
use Magento\Payment\Helper\Data;
@@ -21,7 +20,6 @@
2120
*/
2221
class Form extends Cc
2322
{
24-
2523
/**
2624
* @var Quote
2725
*/
@@ -48,6 +46,7 @@ class Form extends Cc
4846
* @param Quote $sessionQuote
4947
* @param GatewayConfig $gatewayConfig
5048
* @param CcType $ccType
49+
* @param Data $paymentDataHelper
5150
* @param array $data
5251
*/
5352
public function __construct(
@@ -56,12 +55,14 @@ public function __construct(
5655
Quote $sessionQuote,
5756
GatewayConfig $gatewayConfig,
5857
CcType $ccType,
58+
Data $paymentDataHelper,
5959
array $data = []
6060
) {
6161
parent::__construct($context, $paymentConfig, $data);
6262
$this->sessionQuote = $sessionQuote;
6363
$this->gatewayConfig = $gatewayConfig;
6464
$this->ccType = $ccType;
65+
$this->paymentDataHelper = $paymentDataHelper;
6566
}
6667

6768
/**
@@ -81,7 +82,7 @@ public function getCcAvailableTypes()
8182
*/
8283
public function useCvv()
8384
{
84-
return $this->gatewayConfig->isCvvEnabled();
85+
return $this->gatewayConfig->isCvvEnabled($this->sessionQuote->getStoreId());
8586
}
8687

8788
/**
@@ -90,9 +91,8 @@ public function useCvv()
9091
*/
9192
public function isVaultEnabled()
9293
{
93-
$storeId = $this->_storeManager->getStore()->getId();
9494
$vaultPayment = $this->getVaultPayment();
95-
return $vaultPayment->isActive($storeId);
95+
return $vaultPayment->isActive($this->sessionQuote->getStoreId());
9696
}
9797

9898
/**
@@ -102,7 +102,10 @@ public function isVaultEnabled()
102102
private function getConfiguredCardTypes()
103103
{
104104
$types = $this->ccType->getCcTypeLabelMap();
105-
$configCardTypes = array_fill_keys($this->gatewayConfig->getAvailableCardTypes(), '');
105+
$configCardTypes = array_fill_keys(
106+
$this->gatewayConfig->getAvailableCardTypes($this->sessionQuote->getStoreId()),
107+
''
108+
);
106109

107110
return array_intersect_key($types, $configCardTypes);
108111
}
@@ -116,7 +119,11 @@ private function getConfiguredCardTypes()
116119
private function filterCardTypesForCountry(array $configCardTypes, $countryId)
117120
{
118121
$filtered = $configCardTypes;
119-
$countryCardTypes = $this->gatewayConfig->getCountryAvailableCardTypes($countryId);
122+
$countryCardTypes = $this->gatewayConfig->getCountryAvailableCardTypes(
123+
$countryId,
124+
$this->sessionQuote->getStoreId()
125+
);
126+
120127
// filter card types only if specific card types are set for country
121128
if (!empty($countryCardTypes)) {
122129
$availableTypes = array_fill_keys($countryCardTypes, '');
@@ -131,19 +138,6 @@ private function filterCardTypesForCountry(array $configCardTypes, $countryId)
131138
*/
132139
private function getVaultPayment()
133140
{
134-
return $this->getPaymentDataHelper()->getMethodInstance(ConfigProvider::CC_VAULT_CODE);
135-
}
136-
137-
/**
138-
* Get payment data helper instance
139-
* @return Data
140-
* @deprecated 100.1.0
141-
*/
142-
private function getPaymentDataHelper()
143-
{
144-
if ($this->paymentDataHelper === null) {
145-
$this->paymentDataHelper = ObjectManager::getInstance()->get(Data::class);
146-
}
147-
return $this->paymentDataHelper;
141+
return $this->paymentDataHelper->getMethodInstance(ConfigProvider::CC_VAULT_CODE);
148142
}
149143
}

‎app/code/Magento/Braintree/Block/Payment.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ public function getPaymentConfig()
4848
$payment = $this->config->getConfig()['payment'];
4949
$config = $payment[$this->getCode()];
5050
$config['code'] = $this->getCode();
51+
$config['clientTokenUrl'] = $this->_urlBuilder->getUrl(
52+
'braintree/payment/getClientToken',
53+
['_secure' => true]
54+
);
5155
return json_encode($config, JSON_UNESCAPED_SLASHES);
5256
}
5357

0 commit comments

Comments
 (0)