Skip to content

Commit 8422d49

Browse files
author
Oleksandr Dubovyk
committed
MAGETWO-66510: Javascript error prevents adding/removing categories from existing catalog price rule condition
1 parent 77d76c2 commit 8422d49

File tree

1 file changed

+5
-3
lines changed
  • app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab

1 file changed

+5
-3
lines changed

app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Conditions.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,16 @@ protected function addTabToForm($model, $fieldsetId = 'conditions_fieldset', $fo
147147
$form = $this->_formFactory->create();
148148
$form->setHtmlIdPrefix('rule_');
149149

150+
$conditionsFieldSetId = $model->getConditionsFieldSetId($formName);
151+
150152
$newChildUrl = $this->getUrl(
151-
'catalog_rule/promo_catalog/newConditionHtml/form/' . $model->getConditionsFieldSetId($formName),
153+
'catalog_rule/promo_catalog/newConditionHtml/form/' . $conditionsFieldSetId,
152154
['form_namespace' => $formName]
153155
);
154156

155157
$renderer = $this->_rendererFieldset->setTemplate('Magento_CatalogRule::promo/fieldset.phtml')
156158
->setNewChildUrl($newChildUrl)
157-
->setFieldSetId($model->getConditionsFieldSetId($formName));
159+
->setFieldSetId($conditionsFieldSetId);
158160

159161
$fieldset = $form->addFieldset(
160162
$fieldsetId,
@@ -176,7 +178,7 @@ protected function addTabToForm($model, $fieldsetId = 'conditions_fieldset', $fo
176178
->setRenderer($this->_conditions);
177179

178180
$form->setValues($model->getData());
179-
$this->setConditionFormName($model->getConditions(), $formName, $model->getConditionsFieldSetId($formName));
181+
$this->setConditionFormName($model->getConditions(), $formName, $conditionsFieldSetId);
180182
return $form;
181183
}
182184

0 commit comments

Comments
 (0)