MC-23915: Wrong currency symbol in creditmemo_grid & sales_order_view > creditmemo grid for subtotal & Shipping and Handling fee

engcom-Echo · engcom-Echo · commit 8417b8862743 · 2021-01-12T18:23:34.000+02:00
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Grid/Collection.php b/app/code/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Grid/Collection.php
@@ -53,11 +53,11 @@ protected function _translateCondition($field, $condition)
      */
     protected function _renderFiltersBefore()
     {
-        $this->getSelect()->join(
+        $this->getSelect()->joinLeft(
             ['cgf' => $this->getTable('sales_order_grid')],
             'main_table.order_id = cgf.entity_id',
             [
-                'order_currency_code'=>'order_currency_code'
+                'order_currency_code' => 'order_currency_code',
             ]
         );
     }
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Order/Grid/Collection.php b/app/code/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Order/Grid/Collection.php
@@ -53,11 +53,11 @@ protected function _translateCondition($field, $condition)
      */
     protected function _renderFiltersBefore()
     {
-        $this->getSelect()->join(
+        $this->getSelect()->joinLeft(
             ['cgf' => $this->getTable('sales_order_grid')],
             'main_table.order_id = cgf.entity_id',
             [
-                'order_currency_code'=>'order_currency_code'
+                'order_currency_code' => 'order_currency_code',
             ]
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -53,11 +53,11 @@ protected function _translateCondition($field, $condition)`
`53`	`53`	`*/`
`54`	`54`	`protected function _renderFiltersBefore()`
`55`	`55`	`{`
`56`		`- $this->getSelect()->join(`
	`56`	`+ $this->getSelect()->joinLeft(`
`57`	`57`	`['cgf' => $this->getTable('sales_order_grid')],`
`58`	`58`	`'main_table.order_id = cgf.entity_id',`
`59`	`59`	`[`
`60`		`- 'order_currency_code'=>'order_currency_code'`
	`60`	`+ 'order_currency_code' => 'order_currency_code',`
`61`	`61`	`]`
`62`	`62`	`);`
`63`	`63`	`}`