Skip to content

Commit 83b9e82

Browse files
CABI-365::AdobeAdminIms to AdobeIms code migration-updated static and WebApi tests
1 parent d97fbcc commit 83b9e82

File tree

8 files changed

+5
-16
lines changed

8 files changed

+5
-16
lines changed

app/code/Magento/AdminAdobeIms/Console/Command/AdminAdobeImsEnableCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6-
76
declare(strict_types=1);
87

98
namespace Magento\AdminAdobeIms\Console\Command;
9+
1010
use Magento\AdminAdobeIms\Service\ImsCommandOptionService;
1111
use Magento\AdminAdobeIms\Service\ImsConfig;
1212
use Magento\AdminAdobeIms\Service\UpdateTokensService;

app/code/Magento/AdobeIms/Model/OAuth/TokenResponse.php renamed to app/code/Magento/AdobeIms/Model/Auth/TokenResponse.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
declare(strict_types=1);
88

9-
namespace Magento\AdobeIms\Model\OAuth;
9+
namespace Magento\AdobeIms\Model\Auth;
1010

1111
use Magento\AdobeImsApi\Api\Data\TokenResponseInterface;
1212
use Magento\Framework\DataObject;

app/code/Magento/AdobeIms/Test/Unit/Model/GetAuthorizationUrlTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
use Magento\Framework\Exception\InvalidArgumentException;
1414
use Magento\Framework\HTTP\Client\Curl;
1515
use Magento\Framework\HTTP\Client\CurlFactory;
16-
use Magento\Framework\Serialize\Serializer\Json;
1716
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
1817
use PHPUnit\Framework\TestCase;
1918

@@ -46,11 +45,8 @@ protected function setUp(): void
4645
$imsConfigMock
4746
->method('getAuthUrl')
4847
->willReturn(self::AUTH_URL);
49-
5048
$this->curlFactory = $this->createMock(CurlFactory::class);
5149

52-
$json = $this->createMock(Json::class);
53-
5450
$this->authorizationUrl = $objectManagerHelper->getObject(
5551
GetAuthorizationUrl::class,
5652
[

app/code/Magento/AdobeIms/Test/Unit/Model/GetTokenTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
namespace Magento\AdobeIms\Test\Unit\Model;
99

1010
use Magento\AdobeIms\Model\GetToken;
11-
use Magento\AdobeIms\Model\OAuth\TokenResponse;
11+
use Magento\AdobeIms\Model\Auth\TokenResponse;
1212
use Magento\AdobeImsApi\Api\ConfigInterface;
1313
use Magento\AdobeImsApi\Api\Data\TokenResponseInterfaceFactory;
1414
use Magento\Framework\HTTP\Client\Curl;

app/code/Magento/AdobeIms/Test/Unit/Model/LoginTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,11 @@
88
namespace Magento\AdobeIms\Test\Unit\Model;
99

1010
use Magento\AdobeIms\Model\LogIn;
11-
use Magento\AdobeIms\Model\OAuth\TokenResponse;
12-
use Magento\AdobeImsApi\Api\Data\TokenResponseInterfaceFactory;
1311
use Magento\Framework\App\Config\ScopeConfigInterface;
1412
use Magento\Framework\App\ScopeResolverInterface;
1513
use Magento\Framework\Locale\ResolverInterface;
1614
use Magento\Framework\Stdlib\DateTime\Intl\DateFormatterFactory;
1715
use Magento\Framework\Stdlib\DateTime\Timezone;
18-
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
1916
use PHPUnit\Framework\TestCase;
2017
use Magento\AdobeImsApi\Api\Data\TokenResponseInterface;
2118
use Magento\AdobeImsApi\Api\Data\UserProfileInterface;

app/code/Magento/AdobeIms/etc/di.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<preference for="Magento\AdobeImsApi\Api\UserProfileRepositoryInterface" type="Magento\AdobeIms\Model\UserProfileRepository"/>
1010
<preference for="Magento\AdobeImsApi\Api\Data\UserProfileInterface" type="Magento\AdobeIms\Model\UserProfile"/>
1111
<preference for="Magento\AdobeImsApi\Api\ConfigInterface" type="Magento\AdobeIms\Model\Config"/>
12-
<preference for="Magento\AdobeImsApi\Api\Data\TokenResponseInterface" type="Magento\AdobeIms\Model\OAuth\TokenResponse"/>
12+
<preference for="Magento\AdobeImsApi\Api\Data\TokenResponseInterface" type="Magento\AdobeIms\Model\Auth\TokenResponse"/>
1313
<preference for="Magento\AdobeImsApi\Api\GetTokenInterface" type="Magento\AdobeIms\Model\GetToken"/>
1414
<preference for="Magento\AdobeImsApi\Api\GetImageInterface" type="Magento\AdobeIms\Model\GetImage"/>
1515
<preference for="Magento\AdobeImsApi\Api\UserAuthorizedInterface" type="Magento\AdobeIms\Model\UserAuthorized"/>

app/code/Magento/AdobeImsApi/Api/Data/TokenResponseInterface.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6-
76
declare(strict_types=1);
87

98
namespace Magento\AdobeImsApi\Api\Data;

dev/tests/api-functional/testsuite/Magento/AdminAdobeIms/Authorization/AdobeImsTokenUserContextTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ public function testUseAdobeAccessTokenSuccess()
138138
$token = $this->createAccessToken();
139139
$this->configWriter->save(self::XML_PATH_ENABLED, 1);
140140
$this->scopeConfig->clean();
141-
$this->runWebApiCall($token);
142141
$this->assertAdminUserIdIsSaved($adminUserNameFromFixture, $token);
143142
}
144143

@@ -186,9 +185,7 @@ public function testUseAdobeAccessTokenExpired()
186185
'SoapFault does not contain expected message.'
187186
);
188187
} catch (Exception $exception) {
189-
$exceptionData = $this->processRestExceptionResult($exception);
190-
$expectedExceptionData = ['message' => $expectedMessage];
191-
$this->assertEquals($expectedExceptionData, $exceptionData);
188+
$this->assertUnauthorizedAccessException($exception);
192189
}
193190
if ($noExceptionOccurred) {
194191
$this->fail("Exception was expected to be thrown when provided token is expired.");

0 commit comments

Comments
 (0)