B2B:2037:[AWS S3] [Integration Tests]: Investigate Test Failures in MediaGallerySynchronization & MediaGallerySynchronizationMetadata modules

- Added static fixes and other issues

Author: avattam06

app/code/Magento/MediaGalleryMetadata/Model/Jpeg/ReadFile.php

@@ -112,7 +112,6 @@ public function execute(string $path): FileInterface
 
         if ($marker != self::MARKER_IMAGE_FILE_START) {
             $this->driver->fileClose($resource);
-
             throw new ValidatorException(__('Not a JPEG image'));
         }
 
@@ -151,7 +150,6 @@ private function readMarker($resource): string
 
         if ($data[0] != self::MARKER_PREFIX) {
             $this->driver->fileClose($resource);
-
             throw new LocalizedException(__('File is corrupted'));
         }
 
@@ -172,7 +170,7 @@ private function readCompressedImage($resource): string
             $compressedImage .= $this->read($resource, self::ONE_MEGABYTE);
         } while (!$this->driver->endOfFile($resource));
 
-        $endOfImageMarkerPosition = strpos($compressedImage, self::MARKER_PREFIX.self::MARKER_IMAGE_END);
+        $endOfImageMarkerPosition = strpos($compressedImage, self::MARKER_PREFIX . self::MARKER_IMAGE_END);
 
         if ($endOfImageMarkerPosition !== false) {
             $compressedImage = substr($compressedImage, 0, $endOfImageMarkerPosition);

app/code/Magento/MediaGallerySynchronization/Test/Integration/Model/SynchronizeFilesTest.php

@@ -20,9 +20,6 @@
 
 /**
  * Test for SynchronizeFiles.
- *
- * @internal
- * @coversNothing
  */
 class SynchronizeFilesTest extends TestCase
 {
@@ -54,18 +51,17 @@ protected function setUp(): void
         $this->synchronizeFiles = Bootstrap::getObjectManager()->get(SynchronizeFilesInterface::class);
         $this->getAssetsByPath = Bootstrap::getObjectManager()->get(GetAssetsByPathsInterface::class);
         $this->mediaDirectory = Bootstrap::getObjectManager()->get(Filesystem::class)
-            ->getDirectoryWrite(
-                DirectoryList::MEDIA
-            )
-        ;
+            ->getDirectoryWrite(DirectoryList::MEDIA);
         $this->driver = $this->mediaDirectory->getDriver();
     }
 
     /**
-     * Test for SynchronizeFiles::execute.
+     * Test for SynchronizeFiles::execute
      *
      * @dataProvider filesProvider
-     *
+     * @param string $file
+     * @param string $title
+     * @param string $source
      * @throws FileSystemException
      * @throws LocalizedException
      */
@@ -84,13 +80,14 @@ public function testExecute(
         $this->synchronizeFiles->execute([$file]);
 
         $loadedAsset = $this->getAssetsByPath->execute([$file])[0];
+
         $this->assertEquals($title, pathinfo($loadedAsset->getTitle(), PATHINFO_FILENAME));
         $this->assertEquals($source, $loadedAsset->getSource());
         $this->driver->deleteFile($modifiableFilePath);
     }
 
     /**
-     * Data provider for testExecute.
+     * Data provider for testExecute
      *
      * @return array[]
      */
@@ -100,8 +97,8 @@ public function filesProvider(): array
             [
                 '/magento.jpg',
                 'magento',
-                'Local',
-            ],
+                'Local'
+            ]
         ];
     }
 }

dev/tests/integration/testsuite/Magento/MediaGallerySynchronizationMetadata/Model/SynchronizeFilesTest.php

@@ -91,6 +91,7 @@ public function testExecute(
 
         $loadedAssets = $this->getAssetsByPath->execute([$file])[0];
         $loadedKeywords = $this->getKeywords($loadedAssets) ?: null;
+        
         $this->assertEquals($title, pathinfo($loadedAssets->getTitle(), PATHINFO_FILENAME));
         $this->assertEquals($description, $loadedAssets->getDescription());
         $this->assertEquals($keywords, $loadedKeywords);