Skip to content

Commit 83a84a3

Browse files
author
Max Souza
committed
Fix code sniffer alerts
1 parent 217ab79 commit 83a84a3

File tree

1 file changed

+31
-28
lines changed

1 file changed

+31
-28
lines changed

‎app/code/Magento/SalesRule/Model/RulesApplier.php

Lines changed: 31 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
67
namespace Magento\SalesRule\Model;
78

89
use Magento\Quote\Model\Quote\Address;
@@ -41,31 +42,32 @@ class RulesApplier
4142

4243
/**
4344
* @param \Magento\SalesRule\Model\Rule\Action\Discount\CalculatorFactory $calculatorFactory
44-
* @param \Magento\Framework\Event\ManagerInterface $eventManager
45-
* @param \Magento\SalesRule\Model\Utility $utility
46-
* @param ChildrenValidationLocator|null $childrenValidationLocator
45+
* @param \Magento\Framework\Event\ManagerInterface $eventManager
46+
* @param \Magento\SalesRule\Model\Utility $utility
47+
* @param ChildrenValidationLocator|null $childrenValidationLocator
4748
*/
4849
public function __construct(
4950
\Magento\SalesRule\Model\Rule\Action\Discount\CalculatorFactory $calculatorFactory,
5051
\Magento\Framework\Event\ManagerInterface $eventManager,
5152
\Magento\SalesRule\Model\Utility $utility,
5253
ChildrenValidationLocator $childrenValidationLocator = null
53-
) {
54+
)
55+
{
5456
$this->calculatorFactory = $calculatorFactory;
5557
$this->validatorUtility = $utility;
5658
$this->_eventManager = $eventManager;
5759
$this->childrenValidationLocator = $childrenValidationLocator
58-
?: ObjectManager::getInstance()->get(ChildrenValidationLocator::class);
60+
?: ObjectManager::getInstance()->get(ChildrenValidationLocator::class);
5961
}
6062

6163
/**
6264
* Apply rules to current order item
6365
*
64-
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
65-
* @param \Magento\SalesRule\Model\ResourceModel\Rule\Collection $rules
66-
* @param bool $skipValidation
67-
* @param mixed $couponCode
68-
* @return array
66+
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
67+
* @param \Magento\SalesRule\Model\ResourceModel\Rule\Collection $rules
68+
* @param bool $skipValidation
69+
* @param mixed $couponCode
70+
* @return array
6971
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
7072
*/
7173
public function applyRules($item, $rules, $skipValidation, $couponCode)
@@ -80,7 +82,7 @@ public function applyRules($item, $rules, $skipValidation, $couponCode)
8082

8183
if (!$skipValidation && !$rule->getActions()->validate($item)) {
8284
if (!$this->childrenValidationLocator->isChildrenValidationRequired($item)) {
83-
continue;
85+
continue;
8486
}
8587
$childItems = $item->getChildren();
8688
$isContinue = true;
@@ -110,8 +112,8 @@ public function applyRules($item, $rules, $skipValidation, $couponCode)
110112
/**
111113
* Add rule discount description label to address object
112114
*
113-
* @param Address $address
114-
* @param \Magento\SalesRule\Model\Rule $rule
115+
* @param Address $address
116+
* @param \Magento\SalesRule\Model\Rule $rule
115117
* @return $this
116118
*/
117119
public function addDiscountDescription($address, $rule)
@@ -123,7 +125,7 @@ public function addDiscountDescription($address, $rule)
123125
$label = $ruleLabel;
124126
} else {
125127
if (strlen($address->getCouponCode())) {
126-
$label = $address->getCouponCode();
128+
$label = $address->getCouponCode();
127129

128130
if ($rule->getDescription()) {
129131
$label = $rule->getDescription();
@@ -142,9 +144,9 @@ public function addDiscountDescription($address, $rule)
142144

143145
/**
144146
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
145-
* @param \Magento\SalesRule\Model\Rule $rule
146-
* @param \Magento\Quote\Model\Quote\Address $address
147-
* @param mixed $couponCode
147+
* @param \Magento\SalesRule\Model\Rule $rule
148+
* @param \Magento\Quote\Model\Quote\Address $address
149+
* @param mixed $couponCode
148150
* @return $this
149151
*/
150152
protected function applyRule($item, $rule, $address, $couponCode)
@@ -160,7 +162,7 @@ protected function applyRule($item, $rule, $address, $couponCode)
160162

161163
/**
162164
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
163-
* @param \Magento\SalesRule\Model\Rule $rule
165+
* @param \Magento\SalesRule\Model\Rule $rule
164166
* @return \Magento\SalesRule\Model\Rule\Action\Discount\Data
165167
*/
166168
protected function getDiscountData($item, $rule)
@@ -186,7 +188,7 @@ protected function getDiscountData($item, $rule)
186188

187189
/**
188190
* @param \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData
189-
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
191+
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
190192
* @return $this
191193
*/
192194
protected function setDiscountData($discountData, $item)
@@ -202,9 +204,9 @@ protected function setDiscountData($discountData, $item)
202204
/**
203205
* Set coupon code to address if $rule contains validated coupon
204206
*
205-
* @param Address $address
206-
* @param \Magento\SalesRule\Model\Rule $rule
207-
* @param mixed $couponCode
207+
* @param Address $address
208+
* @param \Magento\SalesRule\Model\Rule $rule
209+
* @param mixed $couponCode
208210
* @return $this
209211
*/
210212
public function maintainAddressCouponCode($address, $rule, $couponCode)
@@ -223,18 +225,19 @@ public function maintainAddressCouponCode($address, $rule, $couponCode)
223225
/**
224226
* Fire event to allow overwriting of discount amounts
225227
*
226-
* @param \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData
227-
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
228-
* @param \Magento\SalesRule\Model\Rule $rule
229-
* @param float $qty
228+
* @param \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData
229+
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
230+
* @param \Magento\SalesRule\Model\Rule $rule
231+
* @param float $qty
230232
* @return $this
231233
*/
232234
protected function eventFix(
233235
\Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData,
234236
\Magento\Quote\Model\Quote\Item\AbstractItem $item,
235237
\Magento\SalesRule\Model\Rule $rule,
236238
$qty
237-
) {
239+
)
240+
{
238241
$quote = $item->getQuote();
239242
$address = $item->getAddress();
240243

@@ -255,7 +258,7 @@ protected function eventFix(
255258

256259
/**
257260
* @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
258-
* @param int[] $appliedRuleIds
261+
* @param int[] $appliedRuleIds
259262
* @return $this
260263
*/
261264
public function setAppliedRuleIds(\Magento\Quote\Model\Quote\Item\AbstractItem $item, array $appliedRuleIds)

0 commit comments

Comments
 (0)