MC-17003: Update Totals button is missing from Credit Memo page

Author: DianaRusin

app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminCreditMemoActionGroup.xml

@@ -43,19 +43,17 @@
         </arguments>
         <amOnPage url="{{AdminOrderPage.url(orderId)}}" stepKey="navigateToOrderPage"/>
         <click selector="{{AdminOrderDetailsMainActionsSection.creditMemo}}" stepKey="clickCreditMemo"/>
+        <waitForElementVisible selector="{{AdminHeaderSection.pageTitle}}" stepKey="waitForPageTitle"/>
         <see selector="{{AdminHeaderSection.pageTitle}}" userInput="New Memo" stepKey="seeNewMemoPageTitle"/>
     </actionGroup>
     <actionGroup name="SubmitCreditMemoActionGroup">
         <waitForElementVisible selector="{{AdminCreditMemoTotalSection.submitRefundOffline}}" stepKey="waitButtonEnabled"/>
         <click selector="{{AdminCreditMemoTotalSection.submitRefundOffline}}" stepKey="clickSubmitCreditMemo"/>
         <waitForElementVisible selector="{{AdminMessagesSection.successMessage}}" stepKey="waitForMessageAppears"/>
         <see selector="{{AdminMessagesSection.successMessage}}" userInput="You created the credit memo." stepKey="seeCreditMemoCreateSuccess"/>
-        <grabFromCurrentUrl regex="~/order_id/(\d+)/~" stepKey="grabOrderId"/>
-        <seeInCurrentUrl url="{{AdminOrderDetailsPage.url}}$grabOrderId" stepKey="seeViewOrderPageCreditMemo"/>
     </actionGroup>
     <actionGroup name="UpdateCreditMemoTotalsActionGroup">
         <waitForElementVisible selector="{{AdminCreditMemoTotalSection.updateTotals}}" stepKey="waitUpdateTotalsButtonEnabled"/>
         <click selector="{{AdminCreditMemoTotalSection.updateTotals}}" stepKey="clickUpdateTotals"/>
-        <waitForLoadingMaskToDisappear stepKey="waitForUpdateTotals"/>
     </actionGroup>
 </actionGroups>

dev/tests/functional/tests/app/Magento/Sales/Test/Block/Adminhtml/Order/Creditmemo/Totals.php

@@ -49,7 +49,7 @@ class Totals extends \Magento\Sales\Test\Block\Adminhtml\Order\Totals
     private $adjustmentFeeSelector = '#adjustment_negative';
 
     /**
-     * 'Update Totals button css selector.
+     * Update Totals button css selector.
      *
      * @var string
      */

dev/tests/functional/tests/app/Magento/Sales/Test/TestStep/CreateCreditMemoStep.php

@@ -95,7 +95,7 @@ public function run()
             if ($this->compare($items, $refundData)) {
                 $this->orderCreditMemoNew->getFormBlock()->updateQty();
             }
-            $hasChangeTotals = $this->compareRefundTotalsData($refundData);
+            $hasChangeTotals = $this->isTotalsDataChanged($refundData);
             $this->orderCreditMemoNew->getFormBlock()->fillFormData($refundData);
             if ($hasChangeTotals) {
                 $this->orderCreditMemoNew->getTotalsBlock()->clickUpdateTotals();
@@ -122,12 +122,12 @@ protected function getCreditMemoIds()
     }
 
     /**
-     * Compare refund total items.
+     * Is totals data changed.
      *
      * @param array $data
-     * @return int
+     * @return bool
      */
-    private function compareRefundTotalsData(array $data): int
+    private function isTotalsDataChanged(array $data): bool
     {
         $compareData = [
             'shipping_amount' =>
@@ -138,8 +138,8 @@ private function compareRefundTotalsData(array $data): int
                 $this->orderCreditMemoNew->getTotalsBlock()->getAdjustmentFeeElement()->getValue(),
         ];
 
-        foreach ($compareData as $key => $val) {
-            if (isset($data['form_data'][$key]) && $val != $data['form_data'][$key]) {
+        foreach ($compareData as $fieldName => $fieldValue) {
+            if (isset($data['form_data'][$fieldName]) && $fieldValue != $data['form_data'][$fieldName]) {
                 return false;
             }
         }