MAGETWO-88047: Create integration test for Mixed Mode

Sergii Kovalenko · Sergii Kovalenko · commit 835796e0f167 · 2018-02-22T13:56:30.000+02:00
diff --git a/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/Setup/InstallSchema.php b/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/Setup/InstallSchema.php
@@ -17,8 +17,6 @@ class InstallSchema implements InstallSchemaInterface
 {
     /**
      * {@inheritdoc}
-     *
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function install(SchemaSetupInterface $setup, ModuleContextInterface $context)
     {
diff --git a/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/Setup/UpgradeData.php b/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/Setup/UpgradeData.php
@@ -17,9 +17,6 @@ class UpgradeData implements UpgradeDataInterface
 {
     /**
      * {@inheritdoc}
-     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
-     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function upgrade(ModuleDataSetupInterface $setup, ModuleContextInterface $context)
     {
diff --git a/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/Setup/UpgradeSchema.php b/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/Setup/UpgradeSchema.php
@@ -18,8 +18,6 @@ class UpgradeSchema implements UpgradeSchemaInterface
 {
     /**
      * {@inheritdoc}
-     *
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $context)
     {
diff --git a/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/revisions/swap_with_declaration/SomePatch.php b/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/revisions/swap_with_declaration/SomePatch.php
@@ -16,7 +16,6 @@
  */
 class SomePatch implements
     DataPatchInterface,
-    PatchRevertableInterface,
     PatchVersionInterface
 {
     /**
@@ -58,10 +57,6 @@ public function apply()
         $adapter->insert('test_table', ['varchar' => "_ref"]);
     }
 
-    public function revert()
-    {
-    }
-
     /**
      * @return array
      */
diff --git a/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/revisions/swap_with_declaration/SomeSkippedPatch.php b/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/revisions/swap_with_declaration/SomeSkippedPatch.php
@@ -16,7 +16,6 @@
  */
 class SomeSkippedPatch implements
     DataPatchInterface,
-    PatchRevertableInterface,
     PatchVersionInterface
 {
     /**
@@ -57,10 +56,6 @@ public function apply()
         throw new \Exception('This patch should be skipped!');
     }
 
-    public function revert()
-    {
-    }
-
     /**
      * @return array
      */
diff --git a/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/revisions/us_to_us/UpgradeData.php b/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/revisions/us_to_us/UpgradeData.php
@@ -17,9 +17,6 @@ class UpgradeData implements UpgradeDataInterface
 {
     /**
      * {@inheritdoc}
-     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
-     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function upgrade(ModuleDataSetupInterface $setup, ModuleContextInterface $context)
     {
diff --git a/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/revisions/us_to_us/UpgradeSchema.php b/dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule7/revisions/us_to_us/UpgradeSchema.php
@@ -18,8 +18,6 @@ class UpgradeSchema implements UpgradeSchemaInterface
 {
     /**
      * {@inheritdoc}
-     *
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $context)
     {

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@ class InstallSchema implements InstallSchemaInterface`
`17`	`17`	`{`
`18`	`18`	`/**`
`19`	`19`	`* {@inheritdoc}`
`20`		`- *`
`21`		`- * @SuppressWarnings(PHPMD.ExcessiveMethodLength)`
`22`	`20`	`*/`
`23`	`21`	`public function install(SchemaSetupInterface $setup, ModuleContextInterface $context)`
`24`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,6 @@ class UpgradeData implements UpgradeDataInterface`
`17`	`17`	`{`
`18`	`18`	`/**`
`19`	`19`	`* {@inheritdoc}`
`20`		`- * @SuppressWarnings(PHPMD.CyclomaticComplexity)`
`21`		`- * @SuppressWarnings(PHPMD.ExcessiveMethodLength)`
`22`		`- * @SuppressWarnings(PHPMD.NPathComplexity)`
`23`	`20`	`*/`
`24`	`21`	`public function upgrade(ModuleDataSetupInterface $setup, ModuleContextInterface $context)`
`25`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,6 @@ class UpgradeSchema implements UpgradeSchemaInterface`
`18`	`18`	`{`
`19`	`19`	`/**`
`20`	`20`	`* {@inheritdoc}`
`21`		`- *`
`22`		`- * @SuppressWarnings(PHPMD.ExcessiveMethodLength)`
`23`	`21`	`*/`
`24`	`22`	`public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $context)`
`25`	`23`	`{`