7241 Restore old @api method "process" and add a new method

This new method contains the new parameter and will be called from
the old method.

Author: avstudnitz

app/code/Magento/Config/Console/Command/ConfigSet/ProcessorFacade.php

@@ -97,13 +97,31 @@ public function __construct(
      * @param string $scope The configuration scope (default, website, or store)
      * @param string $scopeCode The scope code
      * @param boolean $lock The lock flag
-     * @param string $lockTarget
      * @return string Processor response message
      * @throws ValidatorException If some validation is wrong
-     * @internal param bool $share The share flag
      * @since 100.2.0
+     * @deprecated
+     * @see processWithLockTarget()
+     */
+    public function process($path, $value, $scope, $scopeCode, $lock)
+    {
+        return $this->processWithLockTarget($path, $value, $scope, $scopeCode, $lock);
+    }
+
+
+    /**
+     * Processes config:set command with the option to set a target file.
+     *
+     * @param string $path The configuration path in format section/group/field_name
+     * @param string $value The configuration value
+     * @param string $scope The configuration scope (default, website, or store)
+     * @param string $scopeCode The scope code
+     * @param boolean $lock The lock flag
+     * @param string $lockTarget
+     * @return string Processor response message
+     * @throws ValidatorException If some validation is wrong
      */
-    public function process($path, $value, $scope, $scopeCode, $lock, $lockTarget = ConfigFilePool::APP_ENV)
+    public function processWithLockTarget($path, $value, $scope, $scopeCode, $lock, $lockTarget = ConfigFilePool::APP_ENV)
     {
         try {
             $this->scopeValidator->isValid($scope, $scopeCode);

app/code/Magento/Config/Console/Command/ConfigSetCommand.php

@@ -173,7 +173,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                     $lockTargetPath = ConfigFilePool::APP_CONFIG;
                 }
 
-                return $this->processorFacadeFactory->create()->process(
+                return $this->processorFacadeFactory->create()->processWithLockTarget(
                     $input->getArgument(static::ARG_PATH),
                     $input->getArgument(static::ARG_VALUE),
                     $input->getOption(static::OPTION_SCOPE),

app/code/Magento/Config/Test/Unit/Console/Command/ConfigSet/ProcessorFacadeTest.php

@@ -123,7 +123,7 @@ public function testProcess()
 
         $this->assertSame(
             'Value was saved.',
-            $this->model->process('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false)
+            $this->model->processWithLockTarget('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false)
         );
     }
 
@@ -139,7 +139,7 @@ public function testProcessWithValidatorException(LocalizedException $exception)
             ->method('isValid')
             ->willThrowException($exception);
 
-        $this->model->process('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false);
+        $this->model->processWithLockTarget('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false);
     }
 
     /**
@@ -174,7 +174,7 @@ public function testProcessWithConfigurationMismatchException()
         $this->configMock->expects($this->never())
             ->method('clean');
 
-        $this->model->process('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false);
+        $this->model->processWithLockTarget('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false);
     }
 
     /**
@@ -200,7 +200,7 @@ public function testProcessWithCouldNotSaveException()
         $this->configMock->expects($this->never())
             ->method('clean');
 
-        $this->model->process('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false);
+        $this->model->processWithLockTarget('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false);
     }
 
     public function testExecuteLockEnv()
@@ -220,7 +220,7 @@ public function testExecuteLockEnv()
 
         $this->assertSame(
             'Value was saved in app/etc/env.php and locked.',
-            $this->model->process('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, true)
+            $this->model->processWithLockTarget('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, true)
         );
     }
 
@@ -241,7 +241,7 @@ public function testExecuteLockConfig()
 
         $this->assertSame(
             'Value was saved in app/etc/config.php and locked.',
-            $this->model->process(
+            $this->model->processWithLockTarget(
                 'test/test/test',
                 'test',
                 ScopeConfigInterface::SCOPE_TYPE_DEFAULT,

app/code/Magento/Config/Test/Unit/Console/Command/ConfigSetCommandTest.php

@@ -94,7 +94,7 @@ public function testExecute()
             ->method('create')
             ->willReturn($this->processorFacadeMock);
         $this->processorFacadeMock->expects($this->once())
-            ->method('process')
+            ->method('processWithLockTarget')
             ->willReturn('Some message');
         $this->emulatedAreProcessorMock->expects($this->once())
             ->method('process')

app/code/Magento/Deploy/Model/Mode.php

@@ -217,7 +217,7 @@ private function saveAppConfigs($mode)
         $configs = $this->configProvider->getConfigs($this->getMode(), $mode);
         foreach ($configs as $path => $item) {
             $this->emulatedAreaProcessor->process(function () use ($path, $item) {
-                $this->processorFacadeFactory->create()->process(
+                $this->processorFacadeFactory->create()->processWithLockTarget(
                     $path,
                     $item['value'],
                     ScopeConfigInterface::SCOPE_TYPE_DEFAULT,