MAGETWO-53431: [GITHUB] SOAP API Encoding Object has no 'label' property #4630

Author: Alex Paliarush

app/code/Magento/Webapi/Controller/Soap/Request/Handler.php

@@ -5,8 +5,6 @@
  */
 namespace Magento\Webapi\Controller\Soap\Request;
 
-use Magento\Framework\Api\ExtensibleDataInterface;
-use Magento\Framework\Api\MetadataObjectInterface;
 use Magento\Framework\Api\SimpleDataObjectConverter;
 use Magento\Framework\Webapi\Authorization;
 use Magento\Framework\Exception\AuthorizationException;
@@ -157,7 +155,7 @@ protected function _prepareResponseData($data, $serviceClassName, $serviceMethod
         } elseif (is_array($data)) {
             $dataType = substr($dataType, 0, -2);
             foreach ($data as $key => $value) {
-                if ($value instanceof ExtensibleDataInterface || $value instanceof MetadataObjectInterface) {
+                if ($value instanceof $dataType) {
                     $result[] = $this->_dataObjectConverter
                         ->convertKeysToCamelCase($this->_dataObjectProcessor->buildOutputDataArray($value, $dataType));
                 } else {

dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductAttributeOptionManagementInterfaceTest.php

@@ -17,7 +17,6 @@ class ProductAttributeOptionManagementInterfaceTest extends WebapiAbstract
 
     public function testGetItems()
     {
-        $this->_markTestAsRestOnly('Fix inconsistencies in WSDL and Data interfaces');
         $testAttributeCode = 'quantity_and_stock_status';
         $expectedOptions = [
             [
@@ -54,7 +53,6 @@ public function testGetItems()
      */
     public function testAdd($optionData)
     {
-        $this->_markTestAsRestOnly('Fix inconsistencies in WSDL and Data interfaces');
         $testAttributeCode = 'select_attribute';
         $serviceInfo = [
             'rest' => [
@@ -100,6 +98,7 @@ public function addDataProvider()
                     AttributeOptionLabelInterface::STORE_ID => 1,
                 ],
             ],
+            AttributeOptionInterface::VALUE => ''
         ];
 
         return [
@@ -121,7 +120,6 @@ public function addDataProvider()
      */
     public function testDelete()
     {
-        $this->_markTestAsRestOnly('Fix inconsistencies in WSDL and Data interfaces');
         $attributeCode = 'select_attribute';
         //get option Id
         $optionList = $this->getAttributeOptions($attributeCode);