Merge branch 'MAGETWO-73002' into 2.2-bugfixes-280218

Author: Dmytro Voskoboinikov

app/code/Magento/CatalogUrlRewrite/Observer/CategoryProcessUrlRewriteSavingObserver.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\CatalogUrlRewrite\Observer;
 
 use Magento\Catalog\Model\Category;
@@ -12,6 +13,9 @@
 use Magento\CatalogUrlRewrite\Model\Map\DataProductUrlRewriteDatabaseMap;
 use Magento\CatalogUrlRewrite\Model\UrlRewriteBunchReplacer;
 use Magento\Framework\Event\ObserverInterface;
+use Magento\Store\Model\ResourceModel\Group\CollectionFactory;
+use Magento\Store\Model\ResourceModel\Group\Collection as StoreGroupCollection;
+use Magento\Framework\App\ObjectManager;
 
 /**
  * Generates Category Url Rewrites after save and Products Url Rewrites assigned to the category that's being saved
@@ -43,28 +47,37 @@ class CategoryProcessUrlRewriteSavingObserver implements ObserverInterface
      */
     private $dataUrlRewriteClassNames;
 
+    /**
+     * @var CollectionFactory
+     */
+    private $storeGroupFactory;
+
     /**
      * @param CategoryUrlRewriteGenerator $categoryUrlRewriteGenerator
      * @param UrlRewriteHandler $urlRewriteHandler
      * @param UrlRewriteBunchReplacer $urlRewriteBunchReplacer
      * @param DatabaseMapPool $databaseMapPool
      * @param string[] $dataUrlRewriteClassNames
+     * @param CollectionFactory|null $storeGroupFactory
      */
     public function __construct(
         CategoryUrlRewriteGenerator $categoryUrlRewriteGenerator,
         UrlRewriteHandler $urlRewriteHandler,
         UrlRewriteBunchReplacer $urlRewriteBunchReplacer,
         DatabaseMapPool $databaseMapPool,
         $dataUrlRewriteClassNames = [
-        DataCategoryUrlRewriteDatabaseMap::class,
-        DataProductUrlRewriteDatabaseMap::class
-        ]
+            DataCategoryUrlRewriteDatabaseMap::class,
+            DataProductUrlRewriteDatabaseMap::class
+        ],
+        CollectionFactory $storeGroupFactory = null
     ) {
         $this->categoryUrlRewriteGenerator = $categoryUrlRewriteGenerator;
         $this->urlRewriteHandler = $urlRewriteHandler;
         $this->urlRewriteBunchReplacer = $urlRewriteBunchReplacer;
         $this->databaseMapPool = $databaseMapPool;
         $this->dataUrlRewriteClassNames = $dataUrlRewriteClassNames;
+        $this->storeGroupFactory = $storeGroupFactory
+            ?: ObjectManager::getInstance()->get(CollectionFactory::class);
     }
 
     /**
@@ -82,6 +95,10 @@ public function execute(\Magento\Framework\Event\Observer $observer)
             return;
         }
 
+        if (!$category->hasData('store_id')) {
+            $this->setCategoryStoreId($category);
+        }
+
         $mapsGenerated = false;
         if ($category->dataHasChangedFor('url_key')
             || $category->dataHasChangedFor('is_anchor')
@@ -102,6 +119,29 @@ public function execute(\Magento\Framework\Event\Observer $observer)
         }
     }
 
+    /**
+     * in case store_id is not set for category then we can assume that it was passed through product import.
+     * store group must have only one root category, so receiving category's path and checking if one of it parts
+     * is the root category for store group, we can set default_store_id value from it to category.
+     * it prevents urls duplication for different stores
+     * ("Default Category/category/sub" and "Default Category2/category/sub")
+     *
+     * @param Category $category
+     * @return void
+     */
+    private function setCategoryStoreId($category)
+    {
+        /** @var StoreGroupCollection $storeGroupCollection */
+        $storeGroupCollection = $this->storeGroupFactory->create();
+
+        foreach ($storeGroupCollection as $storeGroup) {
+            /** @var \Magento\Store\Model\Group $storeGroup */
+            if (in_array($storeGroup->getRootCategoryId(), explode('/', $category->getPath()))) {
+                $category->setStoreId($storeGroup->getDefaultStoreId());
+            }
+        }
+    }
+
     /**
      * Resets used data maps to free up memory and temporary tables
      *