Skip to content

Commit 810f0ba

Browse files
committed
Inconsistent labels for attributes in marketing rules
1 parent 3056e9c commit 810f0ba

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

app/code/Magento/SalesRule/Model/Rule/Condition/Product.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ protected function _addSpecialAttributes(array &$attributes)
2525
$attributes['quote_item_price'] = __('Price in cart');
2626
$attributes['quote_item_row_total'] = __('Row total in cart');
2727

28-
$attributes['parent::category_ids'] = __('Category (Parent only)');
28+
$attributes['parent::category_ids'] = __('Category (Parent Only)');
2929
$attributes['children::category_ids'] = __('Category (Children Only)');
3030
}
3131

@@ -74,8 +74,8 @@ public function loadAttributeOptions()
7474
}
7575
$frontLabel = $attribute->getFrontendLabel();
7676
$attributes[$attribute->getAttributeCode()] = $frontLabel;
77-
$attributes['parent::' . $attribute->getAttributeCode()] = $frontLabel . __('(Parent Only)');
78-
$attributes['children::' . $attribute->getAttributeCode()] = $frontLabel . __('(Children Only)');
77+
$attributes['parent::' . $attribute->getAttributeCode()] = __('%1 (Parent Only)', $frontLabel);
78+
$attributes['children::' . $attribute->getAttributeCode()] = __('%1 (Children Only)', $frontLabel);
7979
}
8080

8181
$this->_addSpecialAttributes($attributes);

app/code/Magento/SalesRule/i18n/en_US.csv

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,3 +173,7 @@ Apply,Apply
173173
"Coupon quantity should be less than or equal to the coupon quantity in the store configuration.","Coupon quantity should be less than or equal to the coupon quantity in the store configuration."
174174
"Code Quantity Limit","Code Quantity Limit"
175175
"For better performance max value allowed is 250,000. Set 0 to disable it.","For better performance max value allowed is 250,000. Set 0 to disable it."
176+
"Category (Parent Only)","Category (Parent Only)"
177+
"Category (Children Only)","Category (Children Only)"
178+
"%1 (Parent Only)","%1 (Parent Only)"
179+
"%1 (Children Only)","%1 (Children Only)"

0 commit comments

Comments
 (0)