MTA-1814: Analyse functional test failures - Sprint 9

Author: Dmytro Aponasenko

dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Product/CreateSimpleProductEntityTest.xml

@@ -316,6 +316,7 @@
             <constraint name="Magento\Catalog\Test\Constraint\AssertProductTierPriceOnProductPage" />
         </variation>
         <variation name="CreateSimpleProductEntityTestVariation18">
+            <data name="issue" xsi:type="string">Bug: MAGETWO-35342</data>
             <data name="description" xsi:type="string">Create product wit suite of custom options</data>
             <data name="product/data/url_key" xsi:type="string">simple-product-%isolation%</data>
             <data name="product/data/name" xsi:type="string">Simple Product %isolation%</data>

dev/tests/functional/tests/app/Magento/ConfigurableProduct/Test/Block/Adminhtml/Product/Edit/Tab/Super/Config/Attribute.php

@@ -165,7 +165,6 @@ protected function createNewVariationSet(array $attribute)
         );
 
         $this->_rootElement->find($this->createNewVariationSet)->click();
-        $newAttribute = $this->getEditAttributeForm();
         $this->getEditAttributeForm()->fill($attributeFixture);
         $this->getEditAttributeForm()->saveAttributeForm();
     }

dev/tests/functional/tests/app/Magento/Sales/Test/Constraint/AssertOrdersInOrdersGrid.php

@@ -21,19 +21,19 @@ class AssertOrdersInOrdersGrid extends AbstractConstraint
      *
      * @param OrderInjectable[] $orders
      * @param OrderIndex $orderIndex
-     * @param array $statuses
+     * @param array $orderStatuses
      * @param AssertOrderInOrdersGrid $assertOrderInOrdersGrid
      * @return void
      */
     public function processAssert(
         $orders,
         OrderIndex $orderIndex,
-        array $statuses,
+        array $orderStatuses,
         AssertOrderInOrdersGrid $assertOrderInOrdersGrid
     ) {
         $orderIndex->open();
         foreach ($orders as $key => $order) {
-            $assertOrderInOrdersGrid->assert($order, $orderIndex, $statuses[$key]);
+            $assertOrderInOrdersGrid->assert($order, $orderIndex, $orderStatuses[$key]);
         }
     }
 

dev/tests/functional/tests/app/Magento/Shipping/Test/Constraint/AssertShipmentInShipmentsGrid.php

@@ -32,12 +32,15 @@ public function processAssert(ShipmentIndex $shipmentIndex, OrderInjectable $ord
         foreach ($ids['shipmentIds'] as $key => $shipmentIds) {
             $filter = [
                 'id' => $shipmentIds,
-                'order_id' => $orderId,
+                'order_id' => $orderId
+            ];
+            $filterQty = [
                 'total_qty_from' => $totalQty[$key],
                 'total_qty_to' => $totalQty[$key],
             ];
+            $shipmentIndex->getShipmentsGrid()->search($filter + $filterQty);
             \PHPUnit_Framework_Assert::assertTrue(
-                $shipmentIndex->getShipmentsGrid()->isRowVisible($filter),
+                $shipmentIndex->getShipmentsGrid()->isRowVisible($filter, false),
                 'Shipment is absent in shipment grid on shipment index page.'
             );
         }