Skip to content

Commit 809977f

Browse files
author
Dale Sikkema
committed
MAGETWO-45159: [ZAP-M2]: Cookie set without secure flag
1 parent e40223c commit 809977f

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

app/code/Magento/Backend/Test/Unit/Model/Session/AdminConfigTest.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,12 @@ public function testSetCookiePathNonDefault()
106106

107107
/**
108108
* Test for setting session name and secure_cookie for admin
109+
* @dataProvider requestSecureDataProvider
110+
* @param $secureRequest
109111
*/
110-
public function testSetSessionSettingsByConstructor()
112+
public function testSetSessionSettingsByConstructor($secureRequest)
111113
{
112114
$sessionName = 'admin';
113-
$secureRequest = true;
114115
$this->requestMock->expects($this->once())->method('isSecure')->willReturn($secureRequest);
115116

116117
$validatorMock = $this->getMockBuilder('Magento\Framework\Validator\ValidatorInterface')
@@ -139,4 +140,9 @@ public function testSetSessionSettingsByConstructor()
139140
$this->assertSame($sessionName, $adminConfig->getName());
140141
$this->assertSame($secureRequest, $adminConfig->getCookieSecure());
141142
}
143+
144+
public function requestSecureDataProvider()
145+
{
146+
return [[true], [false]];
147+
}
142148
}

0 commit comments

Comments
 (0)