Skip to content

Commit 807667e

Browse files
xmavigrybkov
authored andcommitted
MAGETWO-57175: Cannot delete product image
1 parent 4ecd6e8 commit 807667e

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

app/code/Magento/Catalog/Model/Product/Gallery/ReadHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public function addMediaDataToProduct(Product $product, array $mediaEntries)
7878

7979
foreach ($mediaEntries as $mediaEntry) {
8080
$mediaEntry = $this->substituteNullsWithDefaultValues($mediaEntry);
81-
$value['images'][] = $mediaEntry;
81+
$value['images'][$mediaEntry['value_id']] = $mediaEntry;
8282
}
8383
$product->setData($attrCode, $value);
8484
}

dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Gallery/ReadHandlerTest.php

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,18 @@ public function testExecute()
6161

6262
$this->assertArrayHasKey('media_gallery', $data);
6363
$this->assertArrayHasKey('images', $data['media_gallery']);
64-
$image = array_shift($data['media_gallery']['images']);
6564

66-
$this->assertEquals(
67-
'Image Alt Text',
68-
$image['label']
69-
);
65+
$this->assertCount(1, $data['media_gallery']['images']);
66+
foreach ($data['media_gallery']['images'] as $valueId => $imageData) {
67+
$this->assertEquals(
68+
'Image Alt Text',
69+
$imageData['label']
70+
);
71+
$this->assertEquals(
72+
$imageData['value_id'],
73+
$valueId,
74+
"Required by Magento/Catalog/view/adminhtml/templates/catalog/product/helper/gallery.phtml"
75+
);
76+
}
7077
}
7178
}

0 commit comments

Comments
 (0)