MAGETWO-35561: Stabilize story

Author: Yurii Torbyk

app/code/Magento/Payment/Test/Unit/Block/Info/CcTest.php

@@ -157,7 +157,7 @@ public function testGetCcExpDate($ccExpMonth, $ccExpYear)
     public function getCcExpDateDataProvider()
     {
         return [
-            [3, 2015],
+            [2, 2015],
             [12, 2011],
             [01, 2036]
         ];

dev/tests/integration/framework/Magento/TestFramework/Application.php

@@ -331,7 +331,7 @@ public function initialize($overriddenParams = [])
         \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->configure(
             $objectManager->get('Magento\Framework\ObjectManager\DynamicConfigInterface')->getConfiguration()
         );
-        \Magento\Framework\Phrase::setRenderer($objectManager->get('Magento\Framework\Phrase\RendererInterface'));
+        \Magento\Framework\Phrase::setRenderer($objectManager->get('Magento\Framework\Phrase\Renderer\Placeholder'));
     }
 
     /**

dev/tests/integration/framework/Magento/TestFramework/Helper/Memory.php

@@ -50,7 +50,7 @@ public function getRealMemoryUsage()
             // try to use the Windows command line
             // some ports of Unix commands on Windows, such as MinGW, have limited capabilities and cannot be used
             $result = $this->_getWinProcessMemoryUsage($pid);
-        } catch (\Exception $e) {
+        } catch (\Magento\Framework\Exception\LocalizedException $e) {
             // fall back to the Unix command line
             $result = $this->_getUnixProcessMemoryUsage($pid);
         }

dev/tools/Magento/Tools/Di/Code/Scanner/PhpScanner.php

@@ -49,7 +49,7 @@ protected function _findMissingClasses($file, $classReflection, $methodName, $en
                         if (class_exists($missingClassName)) {
                             continue;
                         }
-                    } catch (\Exception $e) {
+                    } catch (\Magento\Framework\Exception\LocalizedException $e) {
                     }
                     $sourceClassName = $this->getSourceClassName($missingClassName, $entityType);
                     if (!class_exists($sourceClassName) && !interface_exists($sourceClassName)) {

dev/tools/Magento/Tools/Di/Code/Scanner/XmlScanner.php

@@ -68,7 +68,7 @@ protected function _filterEntities(array $output)
             $isClassExists = false;
             try {
                 $isClassExists = class_exists($className);
-            } catch (\Exception $e) {
+            } catch (\Magento\Framework\Exception\LocalizedException $e) {
             }
             if (false === $isClassExists) {
                 if (class_exists($entityName) || interface_exists($entityName)) {

lib/internal/Magento/Framework/Code/Generator.php

@@ -69,7 +69,7 @@ public function getGeneratedEntities()
      *
      * @param string $className
      * @return string
-     * @throws \Exception
+     * @throws \Magento\Framework\Exception\LocalizedException
      * @throws \InvalidArgumentException
      */
     public function generateClass($className)
@@ -102,7 +102,9 @@ public function generateClass($className)
         $this->tryToLoadSourceClass($className, $generator);
         if (!($file = $generator->generate())) {
             $errors = $generator->getErrors();
-            throw new \Exception(implode(' ', $errors));
+            throw new \Magento\Framework\Exception\LocalizedException(
+                new \Magento\Framework\Phrase(implode(' ', $errors))
+            );
         }
         $this->includeFile($file);
         return self::GENERATION_SUCCESS;
@@ -167,15 +169,18 @@ public function getObjectManager()
      * @param string $className
      * @param \Magento\Framework\Code\Generator\EntityAbstract $generator
      * @return void
-     * @throws \Exception
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     protected function tryToLoadSourceClass($className, $generator)
     {
         $sourceClassName = $generator->getSourceClassName();
         if (!$this->definedClasses->classLoadable($sourceClassName)) {
             if ($this->generateClass($sourceClassName) !== self::GENERATION_SUCCESS) {
-                throw new \Exception(
-                    sprintf('Source class "%s" for "%s" generation does not exist.', $sourceClassName, $className)
+                throw new \Magento\Framework\Exception\LocalizedException(
+                    new \Magento\Framework\Phrase(
+                        'Source class "%1" for "%2" generation does not exist.',
+                        [$sourceClassName, $className]
+                    )
                 );
             }
         }

lib/internal/Magento/Framework/Code/Test/Unit/GeneratorTest.php

@@ -60,7 +60,7 @@ public function testGetGeneratedEntities()
     }
 
     /**
-     * @expectedException \Exception
+     * @expectedException \Magento\Framework\Exception\LocalizedException
      * @dataProvider generateValidClassDataProvider
      */
     public function testGenerateClass($className, $entityType)
@@ -117,7 +117,7 @@ public function testGenerateClassWithWrongName()
     }
 
     /**
-     * @expectedException \Exception
+     * @expectedException \Magento\Framework\Exception\LocalizedException
      */
     public function testGenerateClassWithError()
     {

lib/internal/Magento/Framework/ObjectManager/Test/Unit/Relations/RuntimeTest.php

@@ -42,7 +42,7 @@ public function getParentsDataProvider()
 
     /**
      * @param $entity
-     * @expectedException \Exception
+     * @expectedException  \Magento\Framework\Exception\LocalizedException
      * @dataProvider nonExistentGeneratorsDataProvider
      */
     public function testHasIfNonExists($entity)

lib/internal/Magento/Framework/Shell.php

@@ -42,7 +42,7 @@ public function __construct(
      * @param string $command Command with optional argument markers '%s'
      * @param string[] $arguments Argument values to substitute markers with
      * @return string Output of an executed command
-     * @throws \Exception If a command returns non-zero exit code
+     * @throws \Magento\Framework\Exception\LocalizedException If a command returns non-zero exit code
      */
     public function execute($command, array $arguments = [])
     {
@@ -51,15 +51,18 @@ public function execute($command, array $arguments = [])
 
         $disabled = explode(',', ini_get('disable_functions'));
         if (in_array('exec', $disabled)) {
-            throw new \Exception("exec function is disabled.");
+            throw new Exception\LocalizedException(new \Magento\Framework\Phrase("exec function is disabled."));
         }
 
         exec($command, $output, $exitCode);
         $output = implode(PHP_EOL, $output);
         $this->log($output);
         if ($exitCode) {
             $commandError = new \Exception($output, $exitCode);
-            throw new \Exception("Command returned non-zero exit code:\n`{$command}`", 0, $commandError);
+            throw new Exception\LocalizedException(
+                new \Magento\Framework\Phrase("Command returned non-zero exit code:\n`%1`", [$command]),
+                $commandError
+            );
         }
         return $output;
     }

lib/internal/Magento/Framework/Test/Unit/ShellTest.php

@@ -111,7 +111,7 @@ public function executeDataProvider()
     }
 
     /**
-     * @expectedException \Exception
+     * @expectedException \Magento\Framework\Exception\LocalizedException
      * @expectedExceptionMessage Command returned non-zero exit code:
      * @expectedExceptionCode 0
      */
@@ -133,7 +133,7 @@ public function testExecuteFailureDetails($command, $commandArgs, $expectedError
             /* Force command to return non-zero exit code */
             $commandArgs[count($commandArgs) - 1] .= ' exit(42);';
             $this->testExecute($command, $commandArgs, ''); // no result is expected in a case of a command failure
-        } catch (\Exception $e) {
+        } catch (\Magento\Framework\Exception\LocalizedException $e) {
             $this->assertInstanceOf('Exception', $e->getPrevious());
             $this->assertEquals($expectedError, $e->getPrevious()->getMessage());
             $this->assertEquals(42, $e->getPrevious()->getCode());