AC-15033:[JS deprecations] Investigate the Unit test Failures

Author: glo71317

dev/tests/js/jasmine/tests/lib/mage/tinymceAdapter.test.js

@@ -10,7 +10,7 @@ define([
 ], function (wysiwygAdapter, _, tinyMCE) {
     'use strict';
 
-    var obj;
+    var obj, originalVarienEvents;
 
     beforeEach(function () {
 
@@ -23,6 +23,32 @@ define([
         Constr.prototype = wysiwygAdapter;
 
         obj = new Constr();
+        
+        // Store original varienEvents if it exists
+        originalVarienEvents = window.varienEvents;
+        
+        // Ensure varienEvents is available for CI environments
+        if (typeof window.varienEvents === 'undefined') {
+            window.varienEvents = function() {
+                this.arrEvents = {};
+                this.attachEvent = function(eventName, callback) {
+                    if (!this.arrEvents[eventName]) {
+                        this.arrEvents[eventName] = [];
+                    }
+                    this.arrEvents[eventName].push(callback);
+                };
+                this.fireEvent = function(eventName, data) {
+                    if (this.arrEvents[eventName]) {
+                        this.arrEvents[eventName].forEach(function(callback) {
+                            if (typeof callback === 'function') {
+                                callback(data);
+                            }
+                        });
+                    }
+                };
+            };
+        }
+        
         obj.eventBus = new window.varienEvents();
         obj.initialize('id', {
             'store_id': 0,
@@ -34,6 +60,15 @@ define([
         obj.setup();
     });
 
+    afterEach(function () {
+        // Restore original varienEvents or remove mock
+        if (originalVarienEvents) {
+            window.varienEvents = originalVarienEvents;
+        } else if (window.varienEvents) {
+            delete window.varienEvents;
+        }
+    });
+
     describe('"openFileBrowser" method', function () {
         it('Opens file browser to given instance', function () {
             expect(_.size(obj.eventBus.arrEvents['open_browser_callback'])).toBe(1);

dev/tests/js/jasmine/tests/lib/mage/wysiwygAdapter.test.js

@@ -33,8 +33,7 @@ define([
          * @param {String} encodedHtml
          */
         function runTests(decodedHtml, encodedHtml) {
-            // Create test case with trailing slash - fix the regex to be more robust
-            var encodedHtmlWithForwardSlashInImgSrc = encodedHtml.replace(/src="([^"]+)"/g, 'src="$1/"');
+            var encodedHtmlWithForwardSlashInImgSrc = encodedHtml.replace(/src="([^"]+)/, 'src="$1/');
 
             describe('"encodeDirectives" method', function () {
                 it('converts media directive img src to directive URL', function () {
@@ -54,21 +53,8 @@ define([
                 it('converts directive URL img src with a trailing forward slash ' +
                     'to media url without a trailing forward slash',
                     function () {
-                        try {
-                            expect(encodedHtmlWithForwardSlashInImgSrc).not.toEqual(encodedHtml);
-                            expect(obj.decodeDirectives(encodedHtmlWithForwardSlashInImgSrc)).toEqual(decodedHtml);
-                        } catch (error) {
-                            // Handle script errors that may occur due to malformed URLs or browser issues
-                            if (error && (error.message === null || error.message === 'Script error.' || 
-                                         (typeof error.message === 'string' && error.message.includes('Script error')))) {
-                                // Log the issue but don't fail the test for script errors
-                                console.warn('Script error encountered in wysiwygAdapter test, marking as pending:', error);
-                                pending('Test pending due to script error in wysiwygAdapter when processing trailing slash URLs');
-                            } else {
-                                // Re-throw actual assertion failures
-                                throw error;
-                            }
-                        }
+                        expect(encodedHtmlWithForwardSlashInImgSrc).not.toEqual(encodedHtml);
+                        expect(obj.decodeDirectives(encodedHtmlWithForwardSlashInImgSrc)).toEqual(decodedHtml);
                     }
                 );
             });