MAGETWO-58594: Static Assets deployment throws errors when redis is used for cache after PR 389

fixes after code_review

Author: AVoskoboinikov

app/code/Magento/Deploy/Console/Command/DeployStaticContentCommand.php

@@ -419,13 +419,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         }
 
-        try {
-            $this->disableCache();
-            return $deployManager->deploy();
-
-        } finally {
-            $this->enableCache();
-        }
+        $this->mockCache();
+        return $deployManager->deploy();
     }
 
     /**
@@ -493,26 +488,12 @@ private function prepareDeployableEntities($filesUtil)
      *
      * @return void
      */
-    private function disableCache()
+    private function mockCache()
     {
         $this->objectManager->configure([
             'preferences' => [
                 Cache::class => DummyCache::class
             ]
         ]);
     }
-
-    /**
-     * Unmock Cache class
-     *
-     * @return void
-     */
-    private function enableCache()
-    {
-        $this->objectManager->configure([
-            'preferences' => [
-                Cache::class => Cache::class
-            ]
-        ]);
-    }
 }

lib/internal/Magento/Framework/App/Cache/Type/Dummy.php

@@ -22,9 +22,7 @@ public function getFrontend()
     /**
      * Pretend to load data from cache by id
      *
-     * @param  string $identifier
-     * @return null
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * {@inheritdoc}
      */
     public function load($identifier)
     {
@@ -34,12 +32,7 @@ public function load($identifier)
     /**
      * Pretend to save data
      *
-     * @param string $data
-     * @param string $identifier
-     * @param array $tags
-     * @param int $lifeTime
-     * @return bool
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * {@inheritdoc}
      */
     public function save($data, $identifier, $tags = [], $lifeTime = null)
     {
@@ -49,9 +42,7 @@ public function save($data, $identifier, $tags = [], $lifeTime = null)
     /**
      * Pretend to remove cached data by identifier
      *
-     * @param string $identifier
-     * @return bool
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * {@inheritdoc}
      */
     public function remove($identifier)
     {
@@ -61,9 +52,7 @@ public function remove($identifier)
     /**
      * Pretend to clean cached data by specific tag
      *
-     * @param array $tags
-     * @return bool
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * {@inheritdoc}
      */
     public function clean($tags = [])
     {