MC-16618: Eliminate @escapeNotVerified in Sales-related Modules

- Resolve admin redundant characters

Author: davemacaulay

app/code/Magento/Sales/view/adminhtml/templates/items/column/qty.phtml

@@ -8,34 +8,34 @@
     <table class="qty-table">
         <tr>
             <th><?= $block->escapeHtml(__('Ordered')); ?></th>
-            <td><?= (int)$item->getQtyOrdered() * 1 ?></td>
+            <td><?= (int) $item->getQtyOrdered() ?></td>
         </tr>
 
         <?php if ((float)$item->getQtyInvoiced()) : ?>
             <tr>
                 <th><?= $block->escapeHtml(__('Invoiced')); ?></th>
-                <td><?= (int)$item->getQtyInvoiced() * 1 ?></td>
+                <td><?= (int) $item->getQtyInvoiced() ?></td>
             </tr>
         <?php endif; ?>
 
         <?php if ((float)$item->getQtyShipped()) : ?>
             <tr>
                 <th><?= $block->escapeHtml(__('Shipped')); ?></th>
-                <td><?= (int)$item->getQtyShipped() * 1 ?></td>
+                <td><?= (int) $item->getQtyShipped() ?></td>
             </tr>
         <?php endif; ?>
 
         <?php if ((float)$item->getQtyRefunded()) : ?>
             <tr>
                 <th><?= $block->escapeHtml(__('Refunded')); ?></th>
-                <td><?= (int)$item->getQtyRefunded() * 1 ?></td>
+                <td><?= (int) $item->getQtyRefunded() ?></td>
             </tr>
         <?php endif; ?>
 
         <?php if ((float)$item->getQtyCanceled()) : ?>
             <tr>
                 <th><?= $block->escapeHtml(__('Canceled')); ?></th>
-                <td><?= (int)$item->getQtyCanceled() * 1 ?></td>
+                <td><?= (int) $item->getQtyCanceled() ?></td>
             </tr>
         <?php endif; ?>
 

app/code/Magento/Sales/view/adminhtml/templates/order/create/items/grid.phtml

@@ -115,7 +115,7 @@
                         <td class="col-qty">
                             <input name="item[<?= (int) $_item->getId() ?>][qty]"
                                    class="input-text item-qty admin__control-text"
-                                   value="<?= (int) $_item->getQty()*1 ?>"
+                                   value="<?= (int) $_item->getQty() ?>"
                                    maxlength="12" />
                         </td>
                         <td class="col-subtotal col-price">

app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar/items.phtml

@@ -105,7 +105,7 @@
                                            type="checkbox"
                                            class="admin__control-checkbox"
                                            name="sidebar[<?= $block->escapeHtmlAttr($block->getSidebarStorageAction()) ?>][<?= (int) $block->getIdentifierId($_item) ?>]"
-                                           value="<?= $block->canDisplayItemQty() ? (int) $_item->getQty()*1 : 1 ?>"
+                                           value="<?= $block->canDisplayItemQty() ? (int) $_item->getQty() : 1 ?>"
                                            title="<?= $block->escapeHtml(__('Add To Order')) ?>"/>
                                     <label class="admin__field-label"
                                            for="sidebar-<?= $block->escapeHtmlAttr($block->getSidebarStorageAction()) ?>-<?= (int) $block->getIdentifierId($_item) ?>">

app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items.phtml

@@ -13,7 +13,7 @@
         <span class="title"><?= $block->escapeHtml(__('Items to Refund')) ?></span>
     </div>
 
-    <?php if (!empty($_items)) : ?>
+    <?php if (count($_items)) : ?>
     <div class="admin__table-wrapper">
         <table class="data-table admin__table-primary order-creditmemo-tables">
             <thead>

app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items/renderer/default.phtml

@@ -29,9 +29,9 @@
         <input type="text"
                class="input-text admin__control-text qty-input"
                name="creditmemo[items][<?= (int) $_item->getOrderItemId() ?>][qty]"
-               value="<?= (int) $_item->getQty()*1 ?>"/>
+               value="<?= (int) $_item->getQty() ?>"/>
     <?php else : ?>
-        <?= (int) $_item->getQty()*1 ?>
+        <?= (int) $_item->getQty() ?>
     <?php endif; ?>
     </td>
     <td class="col-subtotal">

app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/totals/adjustments.phtml

@@ -21,7 +21,7 @@
         <td>
             <input type="text"
                    name="creditmemo[adjustment_positive]"
-                   value="<?= /* @noEscape */ $_source->getBaseAdjustmentPositive()*1 ?>"
+                   value="<?= /* @noEscape */ $_source->getBaseAdjustmentPositive() ?>"
                    class="input-text admin__control-text not-negative-amount"
                    id="adjustment_positive" />
         </td>
@@ -31,7 +31,7 @@
         <td>
             <input type="text"
                    name="creditmemo[adjustment_negative]"
-                   value="<?= /* @noEscape */ $_source->getBaseAdjustmentNegative()*1 ?>"
+                   value="<?= /* @noEscape */ $_source->getBaseAdjustmentNegative() ?>"
                    class="input-text admin__control-text not-negative-amount"
                    id="adjustment_negative"/>
             <script>

app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/form.phtml

@@ -62,7 +62,7 @@
 </section>
 <?php $_items = $block->getCreditmemo()->getAllItems() ?>
 
-<?php if (!empty($_items)) : ?>
+<?php if (count($_items)) : ?>
 <div id="creditmemo_items_container">
     <?= $block->getChildHtml('creditmemo_items') ?>
 </div>

app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items/renderer/default.phtml

@@ -13,7 +13,7 @@
     <td class="col-price">
         <?= $block->getColumnHtml($_item, 'price') ?>
     </td>
-    <td class="col-qty"><?= (int) $_item->getQty()*1 ?></td>
+    <td class="col-qty"><?= (int) $_item->getQty() ?></td>
     <td class="col-subtotal">
         <?= $block->getColumnHtml($_item, 'subtotal') ?>
     </td>

app/code/Magento/Sales/view/adminhtml/templates/order/details.phtml

@@ -41,7 +41,7 @@ $_order = $block->getOrder() ?>
             <br /><?= $block->escapeHtml(__('Message:')) ?><br /> <?= $block->escapeHtml($_giftMessage->getMessage()) ?>
             <?php endif; ?>
             </td>
-            <td align="center" valign="top" style="padding:3px 9px"><?= (int) $_item->getQtyOrdered()*1 ?></td>
+            <td align="center" valign="top" style="padding:3px 9px"><?= (int) $_item->getQtyOrdered() ?></td>
             <td align="right" valign="top" style="padding:3px 9px"><?= /* @noEscape */ $_order->formatPrice($_item->getRowTotal()) ?></td>
         </tr>
 <?php endforeach; ?>

app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items/renderer/default.phtml

@@ -16,9 +16,9 @@
     <?php if ($block->canEditQty()) : ?>
         <input type="text" class="input-text admin__control-text qty-input"
                name="invoice[items][<?= (int) $_item->getOrderItemId() ?>]"
-               value="<?= (int) $_item->getQty()*1 ?>"/>
+               value="<?= (int) $_item->getQty() ?>"/>
     <?php else : ?>
-        <?= (int) $_item->getQty()*1 ?>
+        <?= (int) $_item->getQty() ?>
     <?php endif; ?>
     </td>
     <td class="col-subtotal">