#37509 | Verification added to redis preloading to prevent array_combine receiving false as second argument

LeanderFS · LeanderFS · commit 7d8c0c807851 · 2023-05-17T12:03:00.000+02:00
diff --git a/lib/internal/Magento/Framework/Cache/Backend/Redis.php b/lib/internal/Magento/Framework/Cache/Backend/Redis.php
@@ -51,7 +51,10 @@ public function load($id, $doNotTestCacheValidity = false)
                 $redis->hGet(self::PREFIX_KEY . $key, self::FIELD_DATA);
             }
 
-            $this->preloadedData = array_filter(array_combine($this->preloadKeys, $redis->exec()));
+            $redisResponse = $redis->exec();
+            $this->preloadedData = $redisResponse ?
+                array_filter(array_combine($this->preloadKeys, $redisResponse)) :
+                [];
         }
 
         if (isset($this->preloadedData[$id])) {

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,10 @@ public function load($id, $doNotTestCacheValidity = false)`
`51`	`51`	`$redis->hGet(self::PREFIX_KEY . $key, self::FIELD_DATA);`
`52`	`52`	`}`
`53`	`53`
`54`		`- $this->preloadedData = array_filter(array_combine($this->preloadKeys, $redis->exec()));`
	`54`	`+ $redisResponse = $redis->exec();`
	`55`	`+ $this->preloadedData = $redisResponse ?`
	`56`	`+ array_filter(array_combine($this->preloadKeys, $redisResponse)) :`
	`57`	`+ [];`
`55`	`58`	`}`
`56`	`59`
`57`	`60`	`if (isset($this->preloadedData[$id])) {`