Skip to content

Commit 7d73804

Browse files
MAGETWO-73774: [2.3] Custom option price field disallows negative values #7333
1 parent f31c9ab commit 7d73804

File tree

5 files changed

+5
-22
lines changed

5 files changed

+5
-22
lines changed

app/code/Magento/Catalog/Test/Unit/Model/Product/Option/Validator/DefaultValidatorTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ class DefaultValidatorTest extends \PHPUnit\Framework\TestCase
1919
protected $valueMock;
2020

2121
/**
22-
* Class dependencies initialization
23-
*
24-
* @return void
22+
* @inheritdoc
2523
*/
2624
protected function setUp()
2725
{

app/code/Magento/Catalog/Test/Unit/Model/Product/Option/Validator/FileTest.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ class FileTest extends \PHPUnit\Framework\TestCase
1919
protected $valueMock;
2020

2121
/**
22-
* Class dependencies initialization
23-
*
24-
* @return void
22+
* @inheritdoc
2523
*/
2624
protected function setUp()
2725
{
@@ -60,7 +58,6 @@ protected function setUp()
6058
}
6159

6260
/**
63-
* @throws \Zend_Validate_Exception
6461
* @return void
6562
*/
6663
public function testIsValidSuccess()
@@ -78,7 +75,6 @@ public function testIsValidSuccess()
7875
}
7976

8077
/**
81-
* @throws \Zend_Validate_Exception
8278
* @return void
8379
*/
8480
public function testIsValidWithNegativeImageSize()
@@ -99,7 +95,6 @@ public function testIsValidWithNegativeImageSize()
9995
}
10096

10197
/**
102-
* @throws \Zend_Validate_Exception
10398
* @return void
10499
*/
105100
public function testIsValidWithNegativeImageSizeY()

app/code/Magento/Catalog/Test/Unit/Model/Product/Option/Validator/SelectTest.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ class SelectTest extends \PHPUnit\Framework\TestCase
1919
protected $valueMock;
2020

2121
/**
22-
* Class dependencies initialization
23-
*
24-
* @return void
22+
* @inheritdoc
2523
*/
2624
protected function setUp()
2725
{
@@ -106,7 +104,6 @@ public function isValidSuccessDataProvider()
106104
}
107105

108106
/**
109-
* @throws \Zend_Validate_Exception
110107
* @return void
111108
*/
112109
public function testIsValidateWithInvalidOptionValues()
@@ -128,7 +125,6 @@ public function testIsValidateWithInvalidOptionValues()
128125
}
129126

130127
/**
131-
* @throws \Zend_Validate_Exception
132128
* @return void
133129
*/
134130
public function testIsValidateWithEmptyValues()

app/code/Magento/Catalog/Test/Unit/Model/Product/Option/Validator/TextTest.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ class TextTest extends \PHPUnit\Framework\TestCase
1919
protected $valueMock;
2020

2121
/**
22-
* Class dependencies initialization
23-
*
24-
* @return void
22+
* @inheritdoc
2523
*/
2624
protected function setUp()
2725
{
@@ -60,7 +58,6 @@ protected function setUp()
6058
}
6159

6260
/**
63-
* @throws \Zend_Validate_Exception
6461
* @return void
6562
*/
6663
public function testIsValidSuccess()
@@ -77,7 +74,6 @@ public function testIsValidSuccess()
7774
}
7875

7976
/**
80-
* @throws \Zend_Validate_Exception
8177
* @return void
8278
*/
8379
public function testIsValidWithNegativeMaxCharacters()

dev/tests/integration/testsuite/Magento/Catalog/Model/ProductTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ class ProductTest extends \PHPUnit\Framework\TestCase
3636
protected $_model;
3737

3838
/**
39-
* Class dependencies initialization
40-
*
41-
* @return void
39+
* @inheritdoc
4240
*/
4341
protected function setUp()
4442
{

0 commit comments

Comments
 (0)